Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352177 - Include org.eclipse.equinox.console.jaas.fragment project from equinox incubator in the incubator build
Summary: Include org.eclipse.equinox.console.jaas.fragment project from equinox incuba...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 01:41 EDT by Lazar Kirchev CLA
Modified: 2011-11-08 13:36 EST (History)
2 users (show)

See Also:


Attachments
patch (725 bytes, patch)
2011-08-10 14:55 EDT, Kim Moir CLA
no flags Details | Diff
Patch to add the fragment bundle to the build (1010 bytes, patch)
2011-08-11 01:14 EDT, Lazar Kirchev CLA
no flags Details | Diff
patch (1.22 KB, patch)
2011-08-12 10:51 EDT, Kim Moir CLA
no flags Details | Diff
patch (1.23 KB, patch)
2011-08-12 10:51 EDT, Kim Moir CLA
no flags Details | Diff
patch (597 bytes, patch)
2011-08-15 10:38 EDT, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Kirchev CLA 2011-07-15 01:41:48 EDT
In order for the org.eclipse.equinox.console.supportability bundle to provide ssh functionality, it needs the org.eclipse.equinox.console.jaas.fragment bundle as well. Therefore it should be included in the build as well. The project for this bundle is in rt/org.eclipse.equinox/incubator/console.
Comment 1 Kim Moir CLA 2011-08-10 14:37:10 EDT
Can you please update the map files to include this fragment so I can run a test build?
Comment 2 Kim Moir CLA 2011-08-10 14:55:04 EDT
Created attachment 201269 [details]
patch
Comment 3 Thomas Watson CLA 2011-08-10 16:57:39 EDT
(In reply to comment #1)
> Can you please update the map files to include this fragment so I can run a
> test build?

Kim, we are in the middle of migrating to a git repo for the incubator.  I would like to get that building successfully before we make this change.  Make sense?
Comment 4 Kim Moir CLA 2011-08-10 21:45:59 EDT
Sure, that's fine. Let me know when you are ready :-)
Comment 5 Lazar Kirchev CLA 2011-08-11 01:14:32 EDT
Created attachment 201290 [details]
Patch to add the fragment bundle to the build

I provide the patch to the map file, just to be ready when the migration finishes. 
Probably the tag will be different then?
Comment 6 Thomas Watson CLA 2011-08-11 09:38:20 EDT
The nightly incubator build was successful.  I applied Lazar's patch to the incubator map.  Kim, you can run a test build when you are ready.  Thanks!
Comment 7 Kim Moir CLA 2011-08-12 10:51:40 EDT
Created attachment 201402 [details]
patch
Comment 8 Kim Moir CLA 2011-08-12 10:51:59 EDT
Created attachment 201403 [details]
patch
Comment 9 Kim Moir CLA 2011-08-12 10:59:41 EDT
This was fixed for N20110812-2000.

Tom, can you tag the equinox incubator feature for the next build, thanks :-)

Git commits

http://git.eclipse.org/c/equinox/rt.equinox.incubator.git/commit/?id=bd46f4b6673037b844483ca289c71e685b9b6050

http://git.eclipse.org/c/equinox/rt.equinox.incubator.git/commit/?id=942ef8f51fc4f2d85a8508a09940e3dbdd3ce1d5
Comment 10 Thomas Watson CLA 2011-08-12 16:55:47 EDT
(In reply to comment #9)
> Tom, can you tag the equinox incubator feature for the next build, thanks :-)


Thanks Kim.  I also updated the orbit.map to consume the mina and sshd bundles from orbit.  That required a small change to the console bundles in commit:

http://git.eclipse.org/c/equinox/rt.equinox.incubator.git/commit/?id=afb37813fdbaa269b43b6ac0ac01f2a832e85844
Comment 11 Kim Moir CLA 2011-08-15 10:38:14 EDT
Created attachment 201499 [details]
patch

bundle symbolic name for the sshd-core bundle changed and needed to be reflected in the feature.
Comment 12 Kim Moir CLA 2011-11-07 15:10:34 EST
Tom, it looks like the incubator feature needs to be tagged and the maps updated. The comparator in the last i-build complained about it.
Comment 13 Thomas Watson CLA 2011-11-07 17:39:20 EST
(In reply to comment #12)
> Tom, it looks like the incubator feature needs to be tagged and the maps
> updated. The comparator in the last i-build complained about it.

What is it complaining about.  I think the issue is that we are not even building the jaas.fragment anymore since we have moved the console bundles to rt.equinox.bundles and now include them in the equinox and eclipse SDK.  We likely need to add the bundle to the org.eclipse.equinox.core.sdk feature.  I don't want this bundle included in the RCP feature.
Comment 14 Kim Moir CLA 2011-11-08 13:36:57 EST
It's complaining that the version was needlessly incremented.  If I compare the version in master and the tag in the maps there are differences.