Community
Participate
Working Groups
I've used R4E the first time. My first impression was very good and I didn't have any problems to use it. The UI looks very nice and is straight forward to use. I reviewed source code from Mathieu, who setup an informal review. We are still not finished with the whole review process and we might have some more comments later on. Mathieu, feel free to write your own comments. Here are my comments: Missing path in property view for new Files. As reviewer, you don't have a way to find out where the new file is located in the repository. This information is needed, so that the reviewer can also comment on the location of the new file. An anomaly could be created on the location itself. The Description of a anomaly in the property view is in one line only. This makes it hard to read, especially for long descriptions. Anomalies should have an unique ID associated so that it can be cross-referenced. Sometimes, a reviewer wants to cross-reference anomalies, e.g. to indicate that they are related or the same description is applicable for the new anomaly. To find review items, it should be possible to select a base commit. Often during development of a feature multiple commits will be made in a branch and the last commit of the branch needs to be reviewed to the base of the branch.
comments above are from the R4E users: Bernd Huffmann and Mathieu Denis,
The first 2 issues were addressed: >>Missing path in property view for new Files. >>As reviewer, you don't have a way to find out where the new file is located in the repository. This information is needed, so that the reviewer can also comment >>on the location of the new file. An anomaly could be created on the location itself. R4E File Context and Postponed File properties now include the Repository Path, the Project-Relative path and the Absolute Path for all file versions >>The Description of a anomaly in the property view is in one line only. >>This makes it hard to read, especially for long descriptions. This is a limitation of the Eclipse Tabbed properties view (See Bug 348090). THis was addressed by removing wrapping from dialogs, to make it more obvious to the users that they should break their text using line feeds i.e. <CRLF>
Created attachment 202526 [details] absolute path shall not resolve for versions not matching work space
The new path information is quite useful, The only thing missing is to make it consistent e.g. The absolute path should be valid only for the case where the version matches the workspace (target or base) see picture attached Created attachment 202526 [details]
Absolute path adjusted as per Alvaro's comments
For the remaining two items: >Anomalies should have an unique ID associated so that it can be cross-referenced. >Sometimes, a reviewer wants to cross-reference anomalies, e.g. to indicate that they are related or the same description is applicable for the new anomaly. >To find review items, it should be possible to select a base commit. >Often during development of a feature multiple commits will be made in a branch and the last commit of the branch needs to be reviewed to the base of the branch. After discussion with the author of this bug, we agree that the first item should be implemented and R4E should provide a way for the users to uniquely identify anomalies. For the second point, we agree that some tracking mecanism needs to be implemented in R4E so that multiple "review cycles" (i.e. code - review - correrctions to the code cycles) could be done as part of a given review. We will have to discuss how this can be done best. This should be listed as an improvement to R4E.
We will now close this bug. The remaining issues will be tracked as subtasks of bug 372434
