Community
Participate
Working Groups
Build Identifier: Some long running operations (including JMX call) are on the UI thread when saving server configuration after modification of server hostname in server editor. Users experienced a non-responding UI for a few seconds. Reproducible: Always Steps to Reproduce: 1.Open Server Editor and modify the hostname, eg. from localhost to the hosting machine name. 2.Save the change and experience a non-responding UI. 3.
After some investigation, I've found the problem should be resolved by the underline server code,and shouldn't be handled by the framework. However, during the work, I've also noticed an intermittent bug during save of the server configuration. The symptom is the status of the server in the Server View showed [Stopped, Publishing] and an error dialog pops up with message "Publish is not performed since the server is not started. Start the server before performing the publish operation.". Once you click OK, the publish will continual. Eventually, you will see server in a correct status [Started, Synchronized] To reproduce the symptom: 1. Create and start a new local server with host name "localhost" 2. Add an application to this server 3. Create another new local server using the same profile as in step 1, the status of this server should be started after synchronized with the previous one 4. Open server editor for both servers 5. In one server editor, change the host name to the machine's name. In my case, I changed it to "abc" and save it 6. If you keep on changing the host name from "localhost" to "abc" and vice versa from "abc" to "localhost". you will hit this problem in a couple of tries
Created attachment 200861 [details] Patch v1.0 The change for autopublish from the Server to the ServerWorkingCopy will prevent the issue described by Christine in comment #2 from occurring. Tests run: 1. Christine ran the scenario using her server adapter and the issue was fixed 2. Regression: I used Tomacat with auto publish on and ensured that modifications to the server's editor caused an automatic publish (such as changing the server's name). My dynamic web project would publish without any issues. This behaviour is consistent with the behehaviour before the patch.
(In reply to comment #2) > Created attachment 200861 [details] > Patch v1.0 > > The change for autopublish from the Server to the ServerWorkingCopy will > prevent the issue described by Christine in comment #2 from occurring. > > Tests run: > 1. Christine ran the scenario using her server adapter and the issue was fixed > 2. Regression: I used Tomacat with auto publish on and ensured that > modifications to the server's editor caused an automatic publish (such as > changing the server's name). My dynamic web project would publish without any > issues. This behaviour is consistent with the behehaviour before the patch. Sorry, to avoid confusion, I meant "regression test" for tests run #2, not that the tests run caused a regression
Changes looks good with sufficient test coverage on both the specific adopter's server type and also on tomcat server.
Code released to 32M, 33M, HEAD
New Gerrit change created: https://git.eclipse.org/r/109058
