Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351990 - [DB][Mysql] Default BLOB size is not sufficient
Summary: [DB][Mysql] Default BLOB size is not sufficient
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.net4j.db (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Egidijus Vaisnora CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-13 11:12 EDT by Egidijus Vaisnora CLA
Modified: 2012-09-21 07:18 EDT (History)
2 users (show)

See Also:
stepper: review+

Attachments
Patch (1.47 KB, patch)
2011-07-13 11:14 EDT, Egidijus Vaisnora CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-07-13 11:12:35 EDT 
BLOB type is mapped to MySQL BLOB type, however it's default size is too small ~ 64kb. I prefer to increase it to 4G to accept large binary data
Comment 1 Egidijus Vaisnora CLA 2011-07-13 11:14:46 EDT 
Created attachment 199595 [details]
Patch
Comment 2 Stefan Winkler CLA 2011-07-14 02:24:11 EDT 
Is there any drawback when the default size is increased?
If yes, would it make more sense to make the value configurable?
Comment 3 Egidijus Vaisnora CLA 2011-07-14 02:52:31 EDT 
(In reply to comment #2)
> Is there any drawback when the default size is increased?
> If yes, would it make more sense to make the value configurable?

It will increase size of BLOB by the size required to tell length of data. Default BLOB will have 2 byte prefix, large will have 4 byte prefix. http://dev.mysql.com/doc/refman/5.0/en/string-type-overview.html
But anyway, I think your idea with configuration is great and should fulfill everybody needs. Now it seems that each adapter is overloading default types for some reasons.
Comment 4 Egidijus Vaisnora CLA 2011-07-18 03:30:59 EDT 
Committed revision 8719, to TRUNK
Comment 5 Eike Stepper CLA 2012-09-21 07:18:17 EDT 
Closing.