Community
Participate
Working Groups
Sometimes we want declare local CellEditor, that is to say, CellEditor which will be used only in a specific table. In order to do that, - I forced the CellEditor in the table customization file - I didn't declare the file modelcelleditors in the plugin.xml (to hide this cell editor for others tables) -> doing that, there is no active editor in the cell : we have neither the default editor nor the new editor.
Created attachment 199554 [details] a patch for the plugin example to reproduce the bug This patch provides a Custom EString editor (which display a message in the console. I added my custom cell editor in the 2 tableconfigurations files. Currently, the file modelcelleditors is not registered in the plugin.xml, therefore you don't have cell editor for EString... If you declare it, you will use my custom CellEditor I would like to be able to use my custom celleditor without declaring it in the plugin.xml. (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 199897 [details] This patch add the possibility to use local editors (editors not declared in the plugin.xml) (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 199904 [details] This patch add the possibility to use local editors (editors not declared in the plugin.xml) (1) I, Vincent Lorenzo, wrote 100% of the code I've provided. (2) This code contains no cryptography (3) I have the right to contribute the code to Eclipse. (4) I contribute the content under the EPL.
Created attachment 201209 [details] unit test Here is a unit test for this bug.
I committed the unit test in revision 763.
Comment on attachment 199904 [details] This patch add the possibility to use local editors (editors not declared in the plugin.xml) Here is a contribution smaller than 250 lines (135). I've committed this patch with the following modifications: - I’ve renamed registerLocalCellEditor to registerLocalCellEditors - I’ve removed the @SuppressWarnings("static-method") on isInCellEditorRegistry. - I’ve moved the method getBundleNameFor in the class org.eclipse.emf.facet.widgets.celleditors.CellEditorsUtils - I’ve replaced the use of getAllContents() by getContents in the method getBundleNameFor - In getBundleNameFor, I’ve checked that the URI is a plug-in before to get value of the segment 1. Committed revision 764.
Comment on attachment 199904 [details] This patch add the possibility to use local editors (editors not declared in the plugin.xml) I've committed this contribution in the trunk (revision 764) and in the branch 0.1 (revision 768).
This bug can be marked as fixed.
I've merged the unit test into branch 0_1 (revision 770)
Hello Vincent, Please, can you close this bug, if your problem has been solved ? Regards, Grégoire
Sorry Vincent, but this bug has to be closed for the IP log generation.
Comment on attachment 201209 [details] unit test According to comment #5, this patch has been committed.
Comment on attachment 199554 [details] a patch for the plugin example to reproduce the bug I've search for the string "EStringCellEditor" in the sources and I found nothing. That's why I assume that this path has not be committed. => iplog-
