Description Rafal Krzewski 2011-07-12 20:50:36 EDT

Build Identifier: 

Artifact handler definitions for Tycho packaging types declared in https://github.com/sonatype/sonatype-tycho/blob/master/tycho-maven-plugin/src/main/resources/META-INF/plexus/components.xml contain stanzas like
      <configuration>
        <classifier></classifier>
        <extension>jar</extension>
        <type>eclipse-plugin</type>
        <packaging>eclipse-plugin</packaging>
        <language>java</language>
        <addedToClasspath>true</addedToClasspath>
        <includesDependencies>false</includesDependencies>
      </configuration>

This results in artifact classifier being set to empty String. While in most places this is interpreted as no classifier, there is at least one where code gets confused, namely maven-sources-plugin

[INFO] --- maven-source-plugin:2.1.2:jar-no-fork (attach-sources) @ plugin ---
[WARNING] NOT adding sources to artifacts with classifier as Maven only supports one classifier per artifact. Current artifact [org.eclipe.tycho.it.eclipse-repository-release:plugin:eclipse-plugin:1.0.0] has a [] classifier.

I've checked the convention used by maven core: http://svn.apache.org/viewvc/maven/maven-3/tags/maven-3.0/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml?view=markup 
and the artifact handlers that don't use the classifier, omit <classifier> tag completely.

I've applied the same convention to tycho-maven-plugin/.../components.xml and observed that maven-sources-plugin started to behave correctly.

Reproducible: Always

Steps to Reproduce:
1. run mvn org.apache.maven.plugins:maven-source-plugin:2.1.2:jar-no-fork on any Tycho project
2. sources are not packaged