Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351898 - [expressions] Invalid expressions do not show errors in the value column.
Summary: [expressions] Invalid expressions do not show errors in the value column.
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Pawel Piech CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
: 352788 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-12 16:37 EDT by Pawel Piech CLA
Modified: 2011-07-22 10:37 EDT (History)
3 users (show)

See Also:
pawel.1.piech: review? (Randy.Rohrbach)

Attachments
Additional patch. (1.91 KB, patch)
2011-07-14 15:20 EDT, Pawel Piech CLA 		pawel.1.piech: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2011-07-12 16:37:35 EDT 
The expressions view and other views do not always report errors found when trying to evaluate expressions.  The errors are swallowed by the logic which tracks errors per individual properties in the properties update.  I introduced this bug with changes for bug 321932.
Comment 1 Pawel Piech CLA 2011-07-12 16:39:40 EDT 
To reproduce: enter an invalid expression in the expressions view.
Comment 2 CDT Genie CLA 2011-07-12 21:29:32 EDT 
*** cdt cvs genie on behalf of Pawel Piech ***
    Bug 351898 - [expressions] Invalid expressions do not show errors in the
    value column.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=9970e94efa165f20e78a6db09968b707d83ab1d1

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=40ebd77d9dcf90938d864e7ea707cb385181c388
Comment 3 Pawel Piech CLA 2011-07-12 23:54:36 EDT 
(In reply to comment #2)
> *** cdt cvs genie on behalf of Pawel Piech ***
Thank you git genie!  I was still figuring out how to make a retro-active patch for the commit I made :-)

I committed the to master and cdt_8_0
Comment 4 Pawel Piech CLA 2011-07-14 15:20:46 EDT 
Created attachment 199698 [details]
Additional patch.

I added an additional guard to make sure that if a variable fails to evaluate with an error, the DMC's full expression is shown in the expressions column.  This is already the case for the names column.  
The problem does not show up with GDB, but it does with Wind River's debugger.
Comment 5 Pawel Piech CLA 2011-07-21 13:43:25 EDT 
*** Bug 352788 has been marked as a duplicate of this bug. ***
Comment 6 Pawel Piech CLA 2011-07-21 16:33:07 EDT 
*** Bug 352788 has been marked as a duplicate of this bug. ***