Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351883 - StandardCredentialsProvider.getCredentials() ignores password cache
Summary: StandardCredentialsProvider.getCredentials() ignores password cache
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 14:38 EDT by David McKnight CLA
Modified: 2011-07-18 11:34 EDT (History)
1 user (show)

See Also:
ddykstal.eclipse: review+

Attachments
patch to check password store (1.94 KB, patch)
2011-07-12 14:39 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-07-12 14:38:00 EDT 
When a user disconnects from an RSE connection, the in-memory password for the StandardCredentialsProvider is cleared.  If the user then tries to reconnect directly via IConnectorService.connect(IProgressMonitor monitor) the connect will fail because there is no password and StandardCredentialsProvider.getCredentials() doesn't look at the password cache.  If there is null password and user chose to save the password prior then we should pick up the password from the cache.
Comment 1 David McKnight CLA 2011-07-12 14:39:49 EDT 
Created attachment 199524 [details]
patch to check password store
Comment 2 David McKnight CLA 2011-07-12 14:40:58 EDT 
Dave, could you please review this patch?
Comment 3 David McKnight CLA 2011-07-12 15:18:52 EDT 
Thanks for the review, Dave.  I've committed the change to cvs.
Comment 4 Martin Oberhuber CLA 2011-07-18 11:34:25 EDT 
Released > I20110718, tagged as R33x_v201107181530