Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351814 - FocusCellOwnerDrawHighlighter does not clear multi selection coloring properly
Summary: FocusCellOwnerDrawHighlighter does not clear multi selection coloring properly
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: JFace (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.5 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 06:48 EDT by Ivan Furnadjiev CLA
Modified: 2011-10-10 16:32 EDT (History)
0 users

See Also:

Attachments
Proposed patch for v14_Maintenance branch (2.71 KB, patch)
2011-10-10 07:14 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Furnadjiev CLA 2011-07-12 06:48:17 EDT 
Steps to reproduce:
1. Start Controls Demo -> TableViewer Tab
2. Check MULTI checkbox
3. Create Cell Editor
4. Make a multi selection - select with CTRL "Karl", "Sofia" and "Donald" for example
5. Click on "Nero" to select a single item
6. Only the selection coloring from the last (focused) cell is removed. "Karl" and "Sofia" still have the selection background color.
This is a regression introduced with the bugfix for bug 284738.
Comment 1 Ivan Furnadjiev CLA 2011-07-12 10:31:00 EDT 
Fixed by proper implementation of FocusCellOwnerDrawHighlighter#removeSelectionInformation. Did some improvements in FocusCellOwnerDrawHighlighter#focusCellChanged a well.
Comment 2 Ivan Furnadjiev CLA 2011-10-10 07:14:07 EDT 
Created attachment 204868 [details]
Proposed patch for v14_Maintenance branch
Comment 3 Ivan Furnadjiev CLA 2011-10-10 07:19:09 EDT 
Applied patch to v14_Tree_Table_Merge branch.
Comment 4 Ivan Furnadjiev CLA 2011-10-10 16:31:44 EDT 
Based on the comment in bug 261647 comment #3 the attached patched became obsolete. I've open a separate bug 360483 to clean up the selection coloring from FocusCellOwnerDrawHighlighter.