Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351754 - Duplicate ProgressMonitorBridge class
Summary: Duplicate ProgressMonitorBridge class
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 16:44 EDT by Konstantin Komissarchik CLA
Modified: 2021-11-19 09:21 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Komissarchik CLA 2011-07-11 16:44:20 EDT 
A ProgressMonitorBridge class exists in the following two plugins:

org.eclipse.sapphire.platform
org.eclipse.sapphire.ui

The two classes have similar purpose, but not exactly the same implementation. The one in the UI plugin should be eliminated.
Comment 1 Konstantin Komissarchik CLA 2011-07-11 16:48:01 EDT 
Fixed.
Comment 2 Konstantin Komissarchik CLA 2011-07-11 17:27:51 EDT 
It turns out that fixing this is harder than it looks. Adding a dependency from sapphire.ui to sapphire.platform causes a cycle in between features which breaks the commandline build. Reverting the change and deferring to a later release.
Comment 3 Konstantin Komissarchik CLA 2012-04-24 15:17:36 EDT 
To close this issue, I removed the copy of this class in org.eclipse.sapphire.plugin. The placement may need to be revisited when ui core and swt code are fully separated, but it should be good enough for now.
Comment 4 Konstantin Komissarchik CLA 2012-04-26 11:08:19 EDT 
The copy of ProgressMonitoryBridge class in platform plugin is used by adopters. Those usages are non-UI, so they cannot switch to depend on the copy in ui plugin. Restored the class. Deferring indefinitely.