Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351703 - [ui] changing compare mode breaks the icon
Summary: [ui] changing compare mode breaks the icon
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: 1.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 08:30 EDT by Bouchet Stéphane CLA
Modified: 2011-07-20 07:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bouchet Stéphane CLA 2011-07-11 08:30:50 EDT 
Steps to reproduce : 
-compare two ecore models.
-click on the dropdown menu visible in the content viewer (Visualization of Structural Differences )
-choose text compare
-the icon changes from an ecore icon to a 'dummy' one ( should be text icon )
- revert back to 'ecore file compare' does not redisplay the correct icon.


reproducible :
always, using any comparison engines.
Comment 1 Laurent Goubet CLA 2011-07-20 04:31:32 EDT 
I can reproduce this alright ... but I have no idea about what could cause this.

Tomasz, could you point me to the bit of code that handles this icon? (I believe that it should be the icon of the file type; the one that is at the left of the "<label> Compare" label in between the structure and content panes of the compare editor.)
Comment 2 Tomasz Zarna CLA 2011-07-20 06:31:19 EDT 
I think it's org.eclipse.compare.internal.CompareContentViewerSwitchingPane.setImage(Image) called from org.eclipse.compare.CompareViewerSwitchingPane.setInput(Object). Both are in org.eclipse.compare.
Comment 3 Laurent Goubet CLA 2011-07-20 07:55:26 EDT 
Thanks Tomasz, that was it. CompareContentViewerSwitchingPane.setImage(Image) asks the Compare Input for its image ... and I didn't properly implement CompareInput#getImage().

This has now fixed.