Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351671 - F5 (refresh) do not work in makefile editor when resource is out of sync with filesystem
Summary: F5 (refresh) do not work in makefile editor when resource is out of sync with...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 03:39 EDT by Gaetano Santoro CLA
Modified: 2014-01-29 22:54 EST (History)
2 users (show)

See Also:

Attachments
proposed patch (1.79 KB, patch)
2011-07-11 03:40 EDT, Gaetano Santoro CLA 		no flags Details | Diff
proposed patch 2 (1.43 KB, patch)
2011-07-11 08:21 EDT, Gaetano Santoro CLA 		cdtdoug: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gaetano Santoro CLA 2011-07-11 03:39:37 EDT 
Build Identifier: I20110613-1736

F5 (refresh) do not work in makefile editor when resource is out of sync with filesystem

Reproducible: Always

Steps to Reproduce:
1. create an empty makefile project
2. create a makefile file, and close it from the editor
3. edit the makefile outside eclipse editor
4. double click on makefile in project explorer,
the editor shows:

Resource is out of sync with the filesystem: ....

Press 'F5' or select File > Refresh to refresh the file.

but pressing F5 do not work
Comment 1 Gaetano Santoro CLA 2011-07-11 03:40:40 EDT 
Created attachment 199397 [details]
proposed patch

attached patch that fix the problem
Comment 2 Anton Leherbauer CLA 2011-07-11 05:41:40 EDT 
Thanks for the patch.  I believe the correct fix should be to let MakefileEditorActionContributor derive from TextEditorActionContributor, like CEditorActionContributor and ASMEditorActionContributor.
Comment 3 Gaetano Santoro CLA 2011-07-11 08:21:51 EDT 
Created attachment 199411 [details]
proposed patch 2

I fully agree, thanks for the clarification
Comment 4 Anton Leherbauer CLA 2011-07-12 02:10:04 EDT 
Thanks, I have committed it on branches master and cdt_8_0.