Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351570 - Equinox git repos have bad permissions
Summary: Equinox git repos have bad permissions
Status: RESOLVED WORKSFORME
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Git (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 09:31 EDT by Thomas Watson CLA
Modified: 2011-07-09 13:08 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-07-08 09:31:17 EDT
We get errors like this:

error: insufficient permission for adding an object to repository database ./objects

fatal: failed to write object
error: unpack failed: unpack-objects abnormal exit
To ssh://git.eclipse.org/gitroot/equinox/rt.equinox.framework.git
 ! [remote rejected] master -> master (n/a (unpacker error))
error: failed to push some refs to 'ssh://git.eclipse.org/gitroot/equinox/rt.equinox.framework.git'

I think this is similar to bug 350720 and bug 346923.  Could you please fix this up for the following repos?

/gitroot/equinox/rt.equinox.binaries.git
/gitroot/equinox/rt.equinox.framework.git
Comment 1 Thomas Watson CLA 2011-07-08 11:47:46 EDT
I'm not sure this is the same as bug 350720 and bug 346923.  I think the objects/ folder has something wrong with how permissions are configured.  I noticed that directories owned by twatson and hargrave from the objects folder had incorrect groups assigned to them.  I fixed that for the directories owned by twatson.  But the content of the directories of twatson and hargrave are also messed up and only have the read bit set where the directories owned by aniefer seem to be correct.  Is there something wrong with the twatson and hargrave ids that is causing this?
Comment 2 Denis Roy CLA 2011-07-08 16:12:34 EDT
Some of the directories under /gitroot/equinox/rt.equinox.binaries.git didn't have the guid sticky bit set, so I've turned it on. This could be a bad client setting since I see nothing wrong/unusual with the account or the account setup.

For now you should be good... but let's keep an eye on things.
Comment 3 Thomas Watson CLA 2011-07-08 16:35:21 EDT
(In reply to comment #2)
> For now you should be good... but let's keep an eye on things.

I just did a commit and it succeeded.  I think the issue was that we had tried to fix up the permissions for the repo ourselves yesterday when we noticed that the group did not have write access.  In doing that I think we must have removed the guid sticky bit.

Once BJ confirms he can commit I think we can close this bug.  Thanks for your help.
Comment 4 BJ Hargrave CLA 2011-07-09 13:08:14 EDT
I was able to successfully push my commit. So everything seems to be alright now.