Description ZFabrik Mising name 2011-07-08 06:54:38 EDT

Hi

issuing a pull command in jgit-1.0.0.201106090707-r leads to NPE:

Caused by: java.lang.NullPointerException
	at org.eclipse.jgit.api.PullCommand.call(PullCommand.java:149)


The source is like this:

public PullResult call() throws WrongRepositoryStateException,
			InvalidConfigurationException, DetachedHeadException,
			InvalidRemoteException, CanceledException, RefNotFoundException {
	checkCallable();

	monitor.beginTask(JGitText.get().pullTaskName, 2);

	String branchName;
	try {
		String fullBranch = repo.getFullBranch();
[149]		if (!fullBranch.startsWith(Constants.R_HEADS)) {
                    ...

Let's look into method getFullBranch():

public String getFullBranch() throws IOException {
	Ref head = getRef(Constants.HEAD);
	if (head == null)
		return null;
	if (head.isSymbolic())
		return head.getTarget().getName();
	if (head.getObjectId() != null)
		return head.getObjectId().name();
	return null;
}

Obviously getFullBranch() can return null in which case fullBranch.startsWith() will throw a NPE.

Best Regards
Udo