Community
Participate
Working Groups
Build Identifier: M20110210-1200 When I run a systemtap plugin with 'run w/Graph' option and the connection fails It displays the wizard to continue the process. Reproducible: Always Steps to Reproduce: 1. Open the Systemtap IDE 2. Load a stap script 3. Click in 'Run w/Chart' Button 4. A form to enter machine name, user and password is displayed 5. Fill the form with an incorrect machine name or user/password 6. A message saying that the connection failed will be displayed 7. The wizard is displayed and after filling it, it fails.
Created attachment 199272 [details] Patch to fix the reported problem This patch aborts the running processes if the connection to the remote machine fails.
Created attachment 199275 [details] Improved patch to fix the problem The patch I sent in previous comment has 2 incorrect lines. Sorry.
A small change in the patch - the continueRun is modified in buildScript() so it needs to be checked again after buildScript() is invoked. Looks fine otherwise... http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/?id=104be8caedb2f54a28a716d86803beb817101ea1
(In reply to comment #3) > A small change in the patch - the continueRun is modified in buildScript() so > it needs to be checked again after buildScript() is invoked. Looks fine > otherwise... > > http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/?id=104be8caedb2f54a28a716d86803beb817101ea1 Did you apply on Git master branch? Will it be available on Linux Tools 0.8.1?
This was committed too late for 0.8.1 (the deadline we discussed on the mailing list was 1 September). If you're interested in seeing whether or not something is on a particular branch in git, you can use the EGit history view and look for the "Branches" list. I put up a screenshot here: http://fedorapeople.org/~overholt/egit-historyview.png HTH, Andrew
Verified in last release.
