Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351452 - [client] save in the file compare view doesn't work
Summary: [client] save in the file compare view doesn't work
Status: CLOSED DUPLICATE of bug 352165
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 09:58 EDT by Piotr Janik CLA
Modified: 2011-08-30 10:21 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Janik CLA 2011-07-07 09:58:47 EDT 
Save doesn't work in the compare view (i.e. during conflict resolving).

Uncaught TypeError: Object #<Object> has no method 'getFileMetadata'
exports.EditorCommandFactory.EditorCommandFactory.generateEditorCommands.saveCommand.mCommands.Command.nameeditorCommands.js:48

Fix is being prepared.
Comment 1 Piotr Janik CLA 2011-07-07 10:20:33 EDT 
Fix: https://github.com/pjanik/orion.client/tree/bug351452
Comment 2 Felipe Heidrich CLA 2011-07-07 10:51:36 EDT 
(In reply to comment #1)
> Fix: https://github.com/pjanik/orion.client/tree/bug351452

that does not look righ to me.
I would expect the fix to be in the compare editor not in the editorCommands.js that is share by all other editors.
Couldn't you change the inputManager used by the compare editor to retun _fileMetadata in its implementation of getFileMetadata() ?
(I'm not familiar with the compare editor code...)
Comment 3 Piotr Janik CLA 2011-07-07 10:58:07 EDT 
Well, you're right. The problem is that I'm familiar with the compare editor code too. This is just temporary fix, as I don't know why getFileMetadata() isn't available in the compare editor context in contrast to regular editor. 
I will try to investigate this problem in the next few days.
Comment 4 Felipe Heidrich CLA 2011-07-07 11:00:55 EDT 
Thanks Piotr.

Libing, do you know what is going on ?
Comment 5 Piotr Janik CLA 2011-07-18 11:16:19 EDT 

*** This bug has been marked as a duplicate of bug 352165 ***