Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351446 - RWT OSGi Integration should adopt RAP Version number
Summary: RWT OSGi Integration should adopt RAP Version number
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: 1.5 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 09:30 EDT by Holger Staudacher CLA
Modified: 2012-05-07 06:48 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-07-07 09:30:38 EDT
Currently the OSGi integration bundle has the version 1.0.0.qualifier but it's already included in our build. I think we should adopt the current RAP version number 1.5.0 to avoid confusion.
Comment 1 Frank Appel CLA 2011-07-08 01:56:09 EDT
-1

As I consider the unification of bundle versions a bad practice, I would prefer to close this issue as INVALID. But probably I do not find much Allies on this in the team, so I won't start a war over it :-)
Comment 2 Holger Staudacher CLA 2011-07-08 03:24:19 EDT
Regardless if this is a good or bad approach, we are doing this with all RAP bundles for a long time now. I think the OSGi Integration should not be an exception.
Comment 3 Frank Appel CLA 2011-07-08 04:17:09 EDT
Hm - as I told you before, I will not start a war over this but I would prefer to change the practice used with all of the RAP bundles. The current approach leads to new bundle version numbers for each bundle in a release train regardless whether the bundle actually has changes or not. And for the rwt-osgi integration bundle it is the first version, not 1.5 ...
Comment 4 Austin Riddle CLA 2011-07-08 09:27:37 EDT
(In reply to comment #3)
> Hm - as I told you before, I will not start a war over this but I would prefer
> to change the practice used with all of the RAP bundles. The current approach
> leads to new bundle version numbers for each bundle in a release train
> regardless whether the bundle actually has changes or not. And for the rwt-osgi
> integration bundle it is the first version, not 1.5 ...

I really agree with Frank, but in my mind it not worth changing the practice for one bundle at this point in time. However, if in the future we decide to version each bundle, it would be an extra burden to us to enforce and track. The real question is, what is the cost benefit of such a change.  Is the gain worth the extra burden, etc. And also, is there a convention across the community for this? To me the canonical case in point is the use of RWT independent of RAP.  To me it makes a lot of sense that RWT should be versioned differently.
Comment 5 Ralf Sternberg CLA 2012-05-07 06:48:34 EDT
Apparently, Rüdiger already changed the version to 1.5.0 in Sep 2011, probably without noticing this discussion. Since this version has been published in milestone builds already, we can't go back anymore. So I'm closing it as "fixed".

I'm also not happy with our practice of changing the version number regardless of changes and I've opened bug 378646 for this issue.