Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351424 - [terminal] Terminal does not support del and insert key
Summary: [terminal] Terminal does not support del and insert key
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 07:33 EDT by Simon Bernard CLA
Modified: 2011-07-18 11:34 EDT (History)
2 users (show)

See Also:


Attachments
a patch to support insert and del keys (1.86 KB, patch)
2011-07-07 07:52 EDT, Simon Bernard CLA
mober.at+eclipse: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Bernard CLA 2011-07-07 07:33:39 EDT
the insert key is not support.
the del key remove the character before the cursor instead of after.
Comment 1 Simon Bernard CLA 2011-07-07 07:52:59 EDT
Created attachment 199251 [details]
a patch to support insert and del keys

I propose a patch for this bug.
I found the key code here : http://www.novell.com/documentation/extend52/Docs/help/Composer/books/TelnetAppendixB.html

I check with wireshark that putty send the same bytes for this two keys.

I, Simon Bernard, wrote 100% of the attached code from scratch. I am employed by Sierra Wireless, and my company has signed an Eclipse Member Commiter Agreement
Comment 2 Martin Oberhuber CLA 2011-07-07 10:28:22 EDT
Patch looks good to me, I assume you're authorized by your employer to make the contribution under the EPL ?
Comment 3 Simon Bernard CLA 2011-07-07 11:46:17 EDT
I, Simon Bernard, wrote 100% of the attached code from scratch. I am employed
by Sierra Wireless, and my company has signed an Eclipse Member Commiter
Agreement
Comment 4 Martin Oberhuber CLA 2011-07-15 10:45:29 EDT
Sorry to be picky here, but the Member committer agreement doesn't help me here since you're not a committer on the TM Project.

The question is, can you confirm that Sierra Wireless is OK with you making this contribution.

Theoretically, Sierra Wireless could want this code to remain proprietary, and you uploaded it here without their consent. It's very unlikely (especially given the small size of the contribution), so I don't think it's a big deal here... but I did want to make clear that the "authorized by employer" point is important.

So, if you could give a brief "my employer is OK with me contributing" kind of message I'll commit it.

Thanks!
Martin
Comment 5 Simon Bernard CLA 2011-07-18 04:38:27 EDT
I'm sorry.
I hope this will be ok : 
I am authorized by my employer to make this contribution under the EPL.
Comment 6 Martin Oberhuber CLA 2011-07-18 11:34:10 EDT
Released > I20110718, tagged as R33x_v201107181530