Description Peter Kullmann 2011-07-07 04:08:02 EDT

(There have been several bugs with more or less the same problem in earlier versions, eg bug 103907)

In 3.6 and 3.7 a custom definition for a color in a custom theme is not restored. Fonts on the other hand work well. 

I have noticed that ThemeElementHelper.populateRegistry() is called for fonts with the custom theme and the method for colors is called with the default theme and thus missing the values in the preferences. The two calls come from the workbench:

	/*
	 * Initializes the workbench fonts with the stored values.
	 */
	private void initializeFonts() {
		StartupThreading.runWithoutExceptions(new StartupRunnable() {

			public void runWithException() {
				FontDefinition[] fontDefinitions = WorkbenchPlugin.getDefault()
						.getThemeRegistry().getFonts();

				ThemeElementHelper.populateRegistry(getThemeManager()
						.getCurrentTheme(), fontDefinitions, PrefUtil
						.getInternalPreferenceStore());
			}
		});
	}

The second call (using the default theme instead of the current theme):
	/**
	 * Initialize colors defined by the new colorDefinitions extension point.
	 * Note this will be rolled into initializeColors() at some point.
	 * 
	 * @since 3.0
	 */
	private void initializeApplicationColors() {
		StartupThreading.runWithoutExceptions(new StartupRunnable() {

			public void runWithException() {
				ColorDefinition[] colorDefinitions = WorkbenchPlugin
						.getDefault().getThemeRegistry().getColors();
				ThemeElementHelper.populateRegistry(getThemeManager().getTheme(
						IThemeManager.DEFAULT_THEME), colorDefinitions,
						PrefUtil.getInternalPreferenceStore());
			}
		});
	}

Is there a workaround where I could force ThemeElementHelper.populateRegistry() with my custom theme?