Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351367 - Remove the use of the 'deltas' approach
Summary: Remove the use of the 'deltas' approach
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 15:21 EDT by Eric Moffatt CLA
Modified: 2013-10-24 11:50 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-07-06 15:21:30 EDT
Having a separate, parallel mechanism to store the model's contents is, IMO, a bad thing. We should at least look into what happens if we just save / restore the model using EMF's standard patterns and then attempt to manage missing (or updated) bundles 'on the fly'.

The best possible solution would also allow this to take place for Menu / TB contributions as well but if not we can still remove them on shutdown before saving the model.

We will need some way (checksum??) to determine whether there have been any changes to the package structure since the last session ended. The 99% case is that we're starting up in the same state that we shut down in so we should optimize for this.
Comment 1 Thomas Schindl CLA 2011-07-06 16:24:53 EDT
The 99% case is true for deployment but not for development time, where one adds/removes/moves stuff around
Comment 2 Oleg Besedin CLA 2011-07-07 10:11:42 EDT
We also need to check that the final approach works OK for dynamic bundle addition/removal.
Comment 3 Eric Moffatt CLA 2011-09-15 12:52:50 EDT
M2 is done...
Comment 4 Eric Moffatt CLA 2011-10-20 15:01:08 EDT
Moving to M4; once we get trim dragging done it'll be more apparent why this makes sense...we may defer this to 4.3.
Comment 5 Eric Moffatt CLA 2011-12-09 11:33:43 EST
I'll move this to M7 (just so I can move it to 4.3 once the slot shows up), it's essentially off the plate for 4.2 since it's not causing issues....
Comment 6 Eric Moffatt CLA 2012-02-14 14:28:46 EST
The main issue is that we need to come up with some mechanism to prevent contributions from being added multiple times...
Comment 7 Eric Moffatt CLA 2013-10-21 14:59:51 EDT
Already Done...