Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351366 - Allow the hosting of Views and Editors independent of the presentation
Summary: Allow the hosting of Views and Editors independent of the presentation
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 15:11 EDT by Eric Moffatt CLA
Modified: 2019-11-25 15:28 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-07-06 15:11:03 EDT
We have to be able to host a View or Editor in Dialogs / Wizards / within some other part...

The main use case for this is replacing the left-side of the JDT compare editor with a *real* editor. This will showcase 4.x's flexibility.

At the moment this is very difficult. For example the SelectionService only sends notifications when the active part's selection changes...and you can't make a 'discreet' part active (it has no parent, causing issues with 'bringToTop'...).
Comment 1 Eric Moffatt CLA 2011-09-15 12:52:47 EDT
M2 is done...
Comment 2 Eric Moffatt CLA 2011-12-01 15:27:20 EST
Pushed in >20111201.

commit 0d6cd94911dcb221379022563d11ed7f4c71ff91

This is comprised of two parts:

1) Adding a 'hostElement' call to the EModelService (which takes care of the boiler-plate needed to render the hosted element) as well as a corresponding 'isHostedElement' method (used by the PartServiceImpl to allow activation of hosted elements.

2) Changing the EModelService to be a singleton service at the E4Application context's level. There was no need to be creating multiple instances and now that it registers a model listener (to clean up hosted elements on close) we don't want to even instantiate the multiple versions any more (so we only have one listener).
Comment 3 Eric Moffatt CLA 2011-12-09 11:32:08 EST

Moving to M5. This could likely be marked fixed but needs some more soak time...
Comment 4 John Arthorne CLA 2013-08-28 15:39:05 EDT
(In reply to comment #3)
> 
> Moving to M5. This could likely be marked fixed but needs some more soak
> time...

Eric can you clarify what this means. Does hosting of views/editors in dialogs work, or not.
Comment 5 Eric Moffatt CLA 2013-08-29 14:45:55 EDT
The basics work but I was hoping that someone would try it out and provide feedback. I haven't had time to test this at all thoroughly.

If we can finally get to doing some forward looking enhancements the first candidate should be putting an instance of the 'ErrorLog' view directly into the error dialog itself.
Comment 6 Eclipse Genie CLA 2019-11-25 15:28:54 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.