Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351358 - [Compatibility] Toolbar ordering is off in 'Git Repositories' view
Summary: [Compatibility] Toolbar ordering is off in 'Git Repositories' view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-07-06 13:26 EDT by Remy Suen CLA
Modified: 2011-10-26 08:21 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot depicting the problem in question. (12.79 KB, image/png)
2011-07-06 13:26 EDT, Remy Suen CLA 		no flags Details
ToolBar rendering patch v1 (8.15 KB, patch)
2011-07-13 10:54 EDT, Remy Suen CLA 		no flags Details | Diff
ToolBar rendering patch v2 (7.74 KB, patch)
2011-09-12 07:58 EDT, Remy Suen CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-07-06 13:26:23 EDT 
Created attachment 199195 [details]
Screenshot depicting the problem in question.

We have two items at the end of the toolbar instead of the front. From a cursory analysis it looks like we don't have opaque model items representing those items.
Comment 1 Remy Suen CLA 2011-07-12 11:24:29 EDT 
It almost feels like we need a specialized subclass of ToolBarManager here. Right now we have no way of knowing when someone adds or removes contribution items so it is not possible for us to determine when we should reconcile its list of items with the model's collection of opaque items.
Comment 2 Paul Webster CLA 2011-07-13 08:27:14 EDT 
From a compat point of view, we have 2 points where we can reconcile the toolbar:

1) after the createPartControl(*) is called

2) after actionBars.updateActionBars() is called.

Views are not allowed to add things to their toolbar unless they call updateActionBars() (outside of createPartControl(*))

PW
Comment 3 Remy Suen CLA 2011-07-13 10:54:14 EDT 
Created attachment 199590 [details]
ToolBar rendering patch v1

Paul, what do you think of this?
Comment 4 Remy Suen CLA 2011-09-12 07:58:34 EDT 
Created attachment 203145 [details]
ToolBar rendering patch v2
Comment 5 Remy Suen CLA 2011-09-16 12:56:51 EDT 
Ordering is also bad in the 'Breakpoints' view.
Comment 7 Remy Suen CLA 2011-10-26 08:21:48 EDT 
Verified with I20111025-2000 on Windows XP.