Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351350 - Commands stay untoggled in the menu
Summary: Commands stay untoggled in the menu
Status: CLOSED DUPLICATE of bug 362201
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-07-06 12:00 EDT by Remy Suen CLA
Modified: 2012-02-17 08:08 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-07-06 12:00:26 EDT 
In the 'Git Repositories' view there is a 'Hierarchical Branch Layout' and a 'Display Latest Branch Commit' toggle item. Their states should be reflected in the view's menu but this doesn't seem to work in 4.1.
Comment 1 Paul Webster CLA 2011-07-06 21:36:14 EDT 
Are they using the correct command toggle support?  See bug 348780 for an example.

PW
Comment 2 Remy Suen CLA 2011-07-07 08:24:53 EDT 
(In reply to comment #1)
> Are they using the correct command toggle support?  See bug 348780 for an
> example.

It looks right to me anyway.

<command
    categoryId="org.eclipse.egit.ui.commandCategory"
    defaultHandler="org.eclipse.egit.ui.internal.repository.tree.command.ToggleBranchCommitCommand"
    id="org.eclipse.egit.ui.RepositoriesToggleBranchCommit"
    name="%ToggleBranchCommitCommand.name">
  <state
      class="org.eclipse.ui.handlers.RegistryToggleState:false"
      id="org.eclipse.ui.commands.toggleState">
  </state>
</command>
Comment 3 Praveen CLA 2011-08-05 05:48:44 EDT 

*** This bug has been marked as a duplicate of bug 339687 ***
Comment 4 Remy Suen CLA 2012-02-17 08:08:43 EST 

*** This bug has been marked as a duplicate of bug 362201 ***