Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351231 - [prefs] EclipsePreferences#flush method should be synchronized
Summary: [prefs] EclipsePreferences#flush method should be synchronized
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7.2   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 333726 359698 359851 376141
Blocks:
  Show dependency tree
 
Reported: 2011-07-05 15:40 EDT by DJ Houghton CLA
Modified: 2012-04-05 02:56 EDT (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2011-07-05 15:40:30 EDT 
Cloned to track potential release into 3.7.x maintenance branch.

+++ This bug was initially created as a clone of Bug #333726 +++

Hi,

I am using 64-bit Windows 7 Ultimate, with Sun Java 1.6.0_20 JDK installed. I have installed the latest "Eclipse IDE for Java EE developers" for "Windows 64 Bit" platform, it is Helios.
I have installed the latest JPA Diagram Editor from its dedicated Eclipse page: http://wiki.eclipse.org/JPA_Diagram_Editor_Project.


Scenario to reproduce:
0. Create some project with JPA 1.0 facet.
1. Open a clear fresh diagram, and create some entities.
2. Delete all entities as Java sources, remove them from the diagram as well, remove them from the persistence.xml descriptor as well, just leave the <persistence-unit name="TestJPAEditor"> 
</persistence-unit> tag there.
3. Open a clear fresh diagram and create a new Inherited Entity.
4. The entity java source is OK, but according to it, the entity does not inherit the created mapped superclass.

Hint: This behaviour, e.g. deleting everything and starting from the beginning, seems to cause quite strange things to happen.
Comment 2 Kaloyan Raev CLA 2011-07-27 05:12:13 EDT 
Thanks for committing the patch. 

When is the next planned 3.7.x M-build that will include this change?
I see the latest one is from 14 July.
Comment 3 DJ Houghton CLA 2011-07-27 08:15:38 EDT 
There will be a build today once build issues are sorted out.

http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg18795.html

The build schedule is here:

http://eclipse.org/eclipse/platform-releng/buildSchedule.html
Comment 4 Kaloyan Raev CLA 2011-07-27 08:50:45 EDT 
Excellent.
Thanks for the info.
Comment 5 James Blackburn CLA 2011-10-01 03:06:44 EDT 
It looks like this fix is causing cdt to deadlock... Bug 359485
Comment 6 Martin Oberhuber CLA 2011-10-03 08:27:32 EDT 
I agree that the new synchronized block looks inappropriate since it holds Open Calls, causing deadlock. I have filed bug 359698 asking Equinox to fix the regression.
Comment 7 DJ Houghton CLA 2011-10-04 11:00:25 EDT 
Reopening. Analysis of original problem is in Bug 333726 comment 19.