Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351204 - Platform UI bundle should have correct version
Summary: Platform UI bundle should have correct version
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 11:10 EDT by Paul Webster CLA
Modified: 2011-07-12 14:44 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-07-05 11:10:30 EDT
There have been some platform ui changes but no API changes yet.  Our bundle versions should be 3.7.100 then, not 3.8.0.

PW
Comment 1 Dani Megert CLA 2011-07-05 11:11:48 EDT
I think some (JFace?) already have API additions and there the version is fine.
Comment 2 Oleg Besedin CLA 2011-07-07 10:33:11 EDT
You are correct, the workbench change did not need a minor version increase, my bad.

At this point we could leave it at 3.8 or change it to 3.7.100. Considering that it has been 3.8 in two I-builds, I'd prefer to leave it at 3.8 - there is no real harm in that. I'll leave the decision to you.

(Other changes:
- the JFace got an API addition (see bug 203950).
- some graduated e4 core bundles had < 1.0 version numbers. After consulting with John I updated version number to 1.0 on the bundles I modified in Head.)
Comment 3 Prakash Rangaraj CLA 2011-07-07 23:25:54 EDT
(In reply to comment #2)
> At this point we could leave it at 3.8 or change it to 3.7.100. Considering
> that it has been 3.8 in two I-builds, I'd prefer to leave it at 3.8 - there is
> no real harm in that. I'll leave the decision to you.

    Ideally we should be switching to 3.7.100, but considering that there will be API changes anyways, I'll vote for leaving it as 3.8.

    Please reopen if you oppose.
Comment 4 Dani Megert CLA 2011-07-11 03:26:24 EDT
(In reply to comment #2)
> You are correct, the workbench change did not need a minor version increase, my
> bad.
> 
> At this point we could leave it at 3.8 or change it to 3.7.100. Considering
> that it has been 3.8 in two I-builds, I'd prefer to leave it at 3.8 - there is
> no real harm in that. I'll leave the decision to you.
I'm fine with it. Just keep it in mind for future bundle version changes.
Comment 5 Dani Megert CLA 2011-07-11 08:42:56 EDT
There's one issue: org.eclipse.ui has new content but the version has not yet been increased.
Comment 6 Oleg Besedin CLA 2011-07-12 14:44:55 EDT
(In reply to comment #5)
> There's one issue: org.eclipse.ui has new content but the version has not yet
> been increased.

Updated bundle version to 3.7.100 in the R3_development branch. Paul has made the same change in R4_development branch in the bug 349255.