Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351194 - Provide JNLP (Java WebStart) support for Eclipse Features
Summary: Provide JNLP (Java WebStart) support for Eclipse Features
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement with 20 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 10:34 EDT by Kai Toedter CLA
Modified: 2021-04-28 16:55 EDT (History)
15 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Toedter CLA 2011-07-05 10:34:23 EDT
I would like to build a JNLP feature with Tycho. Main use case is to WebStart Eclipse RCP applications that don't use p2. I have successfully ported https://issues.sonatype.org/browse/TYCHO-508 to the current Tycho head, but there is a lot more to do. Here is what I have in mind:

- A new Mojo for JLNP feature creation
- Works similar to the Product Mojo
- The Main Feature has either to create a Template for the master JNLP or some properties that Tycho might generate it on the fly.
- All included features have to be build recursively and JNLP files have to be created.

At the end, the target should look like

target
 main.jnlp
 features
  feature1.jnlp
  feature2.jnlp
  ...
 plugins
  plugin1.jar
  plugin2.jar
  ...

I would be happy to work on the implementation but I am a Maven Newbie and would need some help to getting started.

Is anyone except me interested in having this integrated into Tycho?
Comment 1 Igor Fedorenko CLA 2011-07-06 04:29:50 EDT
As I commented on the original request, JNLP support does not belong to the main tycho source tree. tycho-extras is more appropriate.

.product file better describes webstart applications, so it makes more sense to generate JNLP descriptor from .product file as opposed to feature.xml.

And as a reminded, all code contributions to tycho must come as attachments to bugzilla (see [1] for more details)

[1] http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
Comment 2 Kai Toedter CLA 2011-07-06 13:17:45 EDT
Igor,

tycho-extras would be ok. 

>.product file better describes webstart applications, so it makes more sense
>to generate JNLP descriptor from .product file as opposed to feature.xml.

Most info in the .product is not needed for JNLP. But others that are not part of the .product are. So I still would prefer a feature...
Comment 3 Tobias Oberlies CLA 2011-08-01 04:23:35 EDT
IIRC, Igor said that he had something for this implemented, but it doesn't have the quality yet to go into Tycho. Maybe a "Tycho Incubator" sub-project could be a way for Igor to contribute his POC so that others can bring it to production quality.

@Igor: If we set up an Incubator sub-project, would you go through the contribution process for your POC?
Comment 4 Igor Fedorenko CLA 2011-08-01 10:50:11 EDT
The code I have is of production quality (has adequate test coverage and is actually used) but it has not been updated for recent Tycho versions and, obviously, will need ongoing maintanence. So the plugin is of no real use unless somebody volunteers to update the plugin to work with Tycho 0.13 and maintain it afterwards.
Comment 5 Jason van Zyl CLA 2011-09-15 22:02:05 EDT
I have opened up the source repository which contains the JNLP related code. If anyone is interested in updating this for the most recent version of Tycho they can find the code here:

https://github.com/sonatype/tycho-jnlp-plugin
Comment 6 Kai Toedter CLA 2011-09-16 02:33:15 EDT
Thanks Jason, as soon as I have a bit time, I try it.
Comment 7 Jason van Zyl CLA 2011-09-16 10:05:32 EDT
@Kai I think some changes will be required because we have not worked with this code for a while so it's using Tycho version 0.9.0. I doubt this will work with the most recent version of Tycho. We might spend on some on this in the future but we won't be doing anything for at least a couple months. But the code does work and is production quality.
Comment 8 Simon Goodall CLA 2011-11-30 06:34:54 EST
I've created a fork on github with a version that works against Tycho 0.13.0.

https://github.com/drsgoodall/tycho-jnlp-plugin

Is this something that can be merged in?
Comment 9 Igor Fedorenko CLA 2011-12-05 09:47:50 EST
For the record, tycho-jnlp-plugin is currently at github and we use Sonatype IP process to manage patches. I also merge the only pull request we had so far, so there are no outstanding patches as far as I know.
Comment 10 Tobias Oberlies CLA 2011-12-06 04:57:44 EST
(In reply to comment #9)
> For the record, tycho-jnlp-plugin is currently at github and we use Sonatype IP
> process to manage patches. I also merge the only pull request we had so far, so
> there are no outstanding patches as far as I know.
This is good - this leaves the option to move the code to Eclipse. I don't know the code: is this something we want to have in Tycho or Tycho Extras?
Comment 11 Igor Fedorenko CLA 2011-12-06 07:21:54 EST
(In reply to comment #10)
> (In reply to comment #9)
> > For the record, tycho-jnlp-plugin is currently at github and we use Sonatype IP
> > process to manage patches. I also merge the only pull request we had so far, so
> > there are no outstanding patches as far as I know.
> This is good - this leaves the option to move the code to Eclipse. I don't know
> the code: is this something we want to have in Tycho or Tycho Extras?

Certainly not in Tycho. We may move it to Tycho Extras eventually, but I'd like to see strong user interest first before spending any time on this code.
Comment 12 Kai Zimmermann CLA 2013-03-07 09:24:26 EST
I'm very interested in this feature :)
Comment 13 Igor Fedorenko CLA 2013-03-07 09:31:34 EST
The code is there and you are welcome to use it, but, quite frankly, I do not see strong enough interest in this functionality to justify effort required to move the code to eclipse.org (or make any other changes to the code, for that matter)
Comment 14 Ellen Strnod CLA 2013-03-07 10:21:23 EST
I am interested also, for the record.  Thanks!
Comment 15 Tobias Oberlies CLA 2013-03-07 11:12:29 EST
Please avoid "+1 me too" posts but use Bugzilla's vote functionality instead.
Comment 16 Henno Vermeulen CLA 2014-02-19 06:44:49 EST
It would be very nice if an RCP + Webstart application can be built with Maven Tycho. Note that recent Java 7 updates require adding extra security entries to the manifest. See bug 421294
Comment 17 Henno Vermeulen CLA 2014-02-21 11:11:30 EST
I misunderstood this bug report to mean that tycho-jnlp-plugin does not work at all. In fact I got it working in a toy example based on Goodall's blog at

http://codeiseasy.wordpress.com/tag/jnlp/

Indeed the plugin uses only one template jnlp instead generating a separate extension jnlp like done with the PDE export wizard.

For the time being I used a separate ant task to update the manifests with the new required security entries before signing the jars. It looks like someone recently created a recent pull request that does exactly this, perhaps it can be integrated? https://github.com/sonatype/tycho-jnlp-plugin/pull/2
Comment 18 Tobias Oberlies CLA 2014-02-24 05:10:08 EST
(In reply to comment #17)
> It looks like someone recently created a recent pull request that does exactly 
> this, perhaps it can be integrated?
The tycho-jnlp-plugin is not part of the Tycho project, so this is (currently) not the right channel for such a request.

This bug is for requesting JNLP-support from the Tycho project (e.g. by incorporating the Github project into Tycho), but there are no concrete plans to do this yet. Vote for this issue if you want this to be done.
Comment 19 Christophe Bouhier CLA 2014-02-24 06:49:19 EST
> This bug is for requesting JNLP-support from the Tycho project (e.g. by
> incorporating the Github project into Tycho), but there are no concrete
> plans to do this yet. Vote for this issue if you want this to be done.

There are 11 votes, how many would you need?
Comment 20 Alexander Kurtakov CLA 2020-03-05 15:39:00 EST
JNLP/java web start is dead now AFAICT.