Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351172 - Pop-up bar not working correctly in compartments that are placed inside of compartments
Summary: Pop-up bar not working correctly in compartments that are placed inside of co...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 325683 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-05 08:03 EDT by Ralph Gerbig CLA
Modified: 2011-10-28 10:02 EDT (History)
2 users (show)

See Also:

Attachments
Registers child nodes to ModelingAssitantProvider (1.24 KB, patch)
2011-08-02 07:58 EDT, Ralph Gerbig CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Gerbig CLA 2011-07-05 08:03:54 EDT 
Build Identifier: M20100909-0800

Hi all,

I have the following hirarchy in my model:

diagram
  - compartment 1
   - compartment 2

I place model elements in compartment 2 that can be connected with each other. I would expect the popup bar to enable me to draw these connections. However, it allows me to only draw connections to notes.

Ralph


Reproducible: Always
Comment 1 Ralph Gerbig CLA 2011-07-05 08:22:28 EDT 
XXXModelingAssistantProvider does not seem to be called on those EditParts..

(In reply to comment #0)
> Build Identifier: M20100909-0800
> Hi all,
> I have the following hirarchy in my model:
> diagram
>   - compartment 1
>    - compartment 2
> I place model elements in compartment 2 that can be connected with each other.
> I would expect the popup bar to enable me to draw these connections. However,
> it allows me to only draw connections to notes.
> Ralph
> Reproducible: Always
Comment 2 Michael Golubev CLA 2011-07-25 10:07:14 EDT 
See the Bug #325683 for more details of the problem
Comment 3 Ralph Gerbig CLA 2011-08-02 07:58:35 EDT 
Created attachment 200705 [details]
Registers child nodes to ModelingAssitantProvider

The problem is in the original template. It registers only top level nodes to the ModelingAssistantProviders extension point. This modification also adds child nodes. Better coding style would be to make a union of child nodes and top level nodes instead of two foreach statements. However, I did not get this running.
Comment 4 Mickael Istria CLA 2011-10-28 09:17:55 EDT 
*** Bug 325683 has been marked as a duplicate of this bug. ***
Comment 5 Mickael Istria CLA 2011-10-28 10:02:21 EDT 
Patch tested, ok locally, committed, waiting for IC build.