Community
Participate
Working Groups
Build Identifier: 7.0.2 In class CompletionProposalComputerDescriptor there is the constant MAX_DELAY that specifies the max time of a completion proposal extension may take to calculate the proposals. If an extension takes more time than that an error is shown to the user and the extension is disabled for the future. In our case we sometimes have so huge projects (but also class loading effects of huge emf models) that the completion cannot finish in time. Then the user gets an error message that really confuses him, since he cannot do anything about it. I would like to have: 1. a preference that is used to configure the max delay (enough for me) 2. make it changeable in the UI (to make it complete) Reproducible: Always Steps to Reproduce: See details
Created attachment 200072 [details] Patch for cdt core and git head revision
Created attachment 200073 [details] Patch for cdt doc and git head revision
Created attachment 200075 [details] Updated picture for cdt doc patch
Thanks for the patch, it looks good. However I would suggest to add the option to the "Advanced" page. People might expect that we can enforce this timeout, therefore it should be less prominent. Maybe some more detailed explanation (as a tooltip) would help to avoid any false expectations. And please add a @since tag to the preference constant!
(In reply to comment #4) > Thanks for the patch, it looks good. However I would suggest to add the option > to the "Advanced" page. People might expect that we can enforce this timeout, > therefore it should be less prominent. Maybe some more detailed explanation > (as a tooltip) would help to avoid any false expectations. And please add a > @since tag to the preference constant! Which version should I enter in the since tag 8.0.0 or 8.0.1 or ? The main feature is still version 8.0.0 but 8.0.0 is already out!!??
(In reply to comment #4) > Thanks for the patch, it looks good. However I would suggest to add the option > to the "Advanced" page. People might expect that we can enforce this timeout, > therefore it should be less prominent. Maybe some more detailed explanation > (as a tooltip) would help to avoid any false expectations. And please add a > @since tag to the preference constant! At first I wanted to add to the "Advanced" page but understanding the CodeAssistAdvancedConfigurationBlock is very hard given the little time I had to create the patches! Can you give me some hints on that?
(In reply to comment #5) > Which version should I enter in the since tag 8.0.0 or 8.0.1 or ? > The main feature is still version 8.0.0 but 8.0.0 is already out!!?? The since tag should be @since 5.4. At the same time the plugin version must be incremented to 5.4. Actually, you can leave that to me. (In reply to comment #6) > At first I wanted to add to the "Advanced" page but understanding the > CodeAssistAdvancedConfigurationBlock is very hard given the little time I had > to create the patches! Can you give me some hints on that? Just add the key to the getAllKeys() method and add a text field in createControl(). You can add validation code in validateSettings() (see e.g. SpellingConfigurationBlock).
(In reply to comment #7) > (In reply to comment #5) > > Which version should I enter in the since tag 8.0.0 or 8.0.1 or ? > > The main feature is still version 8.0.0 but 8.0.0 is already out!!?? > > The since tag should be @since 5.4. At the same time the plugin version must > be incremented to 5.4. Actually, you can leave that to me. > > (In reply to comment #6) > > At first I wanted to add to the "Advanced" page but understanding the > > CodeAssistAdvancedConfigurationBlock is very hard given the little time I had > > to create the patches! Can you give me some hints on that? > > Just add the key to the getAllKeys() method and add a text field in > createControl(). You can add validation code in validateSettings() (see e.g. > SpellingConfigurationBlock). Ok, thx. It looked harder than it really is :) I will bring in the patch in a few mins. After that I will create the patch for the doc plugin.
Created attachment 200085 [details] Patch for cdt doc and git head revision
Created attachment 200086 [details] Patch for cdt core and git head revision
Created attachment 200087 [details] Updated picture for cdt doc patch
I committed your patches with a few modifications to wording and layout of the preference UI.
*** cdt git genie on behalf of 351076 *** Bug 351076 - Make MAX_DELAY of editor content assist computation configurable [*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=0dc841b995b7910eefb2f3e84e771aef7349bd00
Assigning to you Anton since you committed the patches.
