Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351073 - [Tooling] Remove "terminate previous launch" option
Summary: [Tooling] Remove "terminate previous launch" option
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Tools (show other bugs)
Version: 1.5   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 2.0 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 07:39 EDT by Ralf Sternberg CLA
Modified: 2012-08-17 05:52 EDT (History)
3 users (show)

See Also:

Attachments
patch for "terminate previous launch" (9.01 KB, patch)
2011-07-08 07:29 EDT, Beyhan Veliev CLA 		no flags Details | Diff
updated patch (9.02 KB, patch)
2011-07-08 10:48 EDT, Beyhan Veliev CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2011-07-04 07:39:29 EDT 
The invaluable "terminate previous launch" option in the RAP launcher has proven to work reliably and it seems there is no reason to ever disable it. In fact, there seems to be no reasonable use case for keeping the previous launch running.
I would therefore suggest to remove the checkbox from the RAP launcher and keep the option always enabled.
Comment 1 Rüdiger Herrmann CLA 2011-07-04 08:37:03 EDT 
+1
Comment 2 Holger Staudacher CLA 2011-07-04 08:43:02 EDT 
+1. I also think it would be useful to push this functionality to PDE. When you are developing an OSGi Application that uses the HttpService it's pretty annoying when you get a BindException all the time [1] ;)

In this case such an UI option would be useful. 

[1] http://eclipsesource.com/blogs/2011/05/04/launch-an-osgi-app-and-automatically-kill-its-running-instance/
Comment 3 Ralf Sternberg CLA 2011-07-04 09:49:09 EDT 
Definitely. Set me on copy if you file a bug against PDE.
Comment 4 Austin Riddle CLA 2011-07-05 09:48:23 EDT 
+1. Users can duplicate a launch configuration and change the port if they want to run multiple instances.
Comment 5 Beyhan Veliev CLA 2011-07-08 07:29:36 EDT 
Created attachment 199323 [details]
patch for "terminate previous launch"

This patch removes the terminate previous launch option.
Comment 6 Holger Staudacher CLA 2011-07-08 09:59:32 EDT 
The patch can't be applied anymore. Beyhan could you make it working again?
Comment 7 Holger Staudacher CLA 2011-07-08 10:08:00 EDT 
I opened bug 351575 against PDE for this feature.
Comment 8 Beyhan Veliev CLA 2011-07-08 10:48:47 EDT 
Created attachment 199338 [details]
updated patch

Patch has been updated to the CVS head.
Comment 9 Ivan Furnadjiev CLA 2012-08-17 05:52:31 EDT 
Applied patch to Git master with commit 1a65f6b870f67030771ce11c47a52e5655006481.