Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 351042 - CommitIntegrityCheck should use #equals when comparing OIDs
Summary: CommitIntegrityCheck should use #equals when comparing OIDs
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 00:50 EDT by Caspar D. CLA
Modified: 2012-09-21 06:50 EDT (History)
1 user (show)

See Also:
stepper: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2011-07-04 00:50:39 EDT 
*** Cloned from Bug 349526 ***
Comment 1 Eike Stepper CLA 2011-07-04 03:43:18 EDT 
I can still see checks like "currentContainerID != CDOID.NULL" and from the context I can not see that currentContainerID!=null. Don't you think it's worth fixing that to "!CDOIDUtil.isNull(currentContainerID)"?
Comment 2 Caspar D. CLA 2011-07-04 05:28:42 EDT 
Committed revision 8583.

(In reply to comment #1)
> I can still see checks like "currentContainerID != CDOID.NULL" and from the
> context I can not see that currentContainerID!=null. Don't you think it's worth
> fixing that to "!CDOIDUtil.isNull(currentContainerID)"?

As discussed on Skype, I can't oversee whether that truly
expresses the same condition under all circumstances. I'm not 
sure about this, and don't have time to look into it today :(
Comment 3 Caspar D. CLA 2011-07-04 05:28:59 EDT 
Resolving.
Comment 4 Eike Stepper CLA 2012-09-21 06:50:24 EDT 
Closing.