Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350975 - [performance] tune up constructor patch from bug 306958
Summary: [performance] tune up constructor patch from bug 306958
Status: RESOLVED WONTFIX
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.2.5   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on: 306958 350976
Blocks:
  Show dependency tree
 
Reported: 2011-07-01 18:18 EDT by Nitin Dahyabhai CLA
Modified: 2011-09-01 14:08 EDT (History)
2 users (show)

See Also:

Attachments
proposed patch (5.46 KB, patch)
2011-07-01 18:19 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2011-07-01 18:18:03 EDT 
A few additional changes on top of those in bug 306958:
-updated build.properties for the test project zip
-optimization to changes in o.e.w.jsdt.internal.compiler.util.Util#getTypeName(IExpression) so it doesn't create lots of extra strings
-remove some redundant lines in ConstructorDeclarationPattern Ian and I found during review
Comment 1 Nitin Dahyabhai CLA 2011-07-01 18:19:58 EDT 
Created attachment 198989 [details]
proposed patch
Comment 2 Nitin Dahyabhai CLA 2011-07-05 10:15:52 EDT 
The addition of the test zip to the build.properties wasn't captured in the patch due to the file being set to Binary at the time.
Comment 3 Nitin Dahyabhai CLA 2011-09-01 14:08:55 EDT 
.