Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350964 - [exceptions] Potential NPE if reciever of prototype field object cannot be resolved
Summary: [exceptions] Potential NPE if reciever of prototype field object cannot be re...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Chris Jaun CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 15:28 EDT by Chris Jaun CLA
Modified: 2011-09-23 11:40 EDT (History)
0 users

See Also:
thatnitind: review+


Attachments
patch (1.25 KB, patch)
2011-07-01 15:30 EDT, Chris Jaun CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jaun CLA 2011-07-01 15:28:41 EDT
The constant value of the FieldReference needs to be set to NotAConstant if all cases if the field is a "prototype" value.

If it doesn't it can lead to NPE's down the road if that field is used in a binary expression that tries to read the constant value.
Comment 1 Chris Jaun CLA 2011-07-01 15:30:13 EDT
Created attachment 198984 [details]
patch
Comment 2 Chris Jaun CLA 2011-07-01 15:36:20 EDT
Checked into 3.2.5 and HEAD.
Comment 3 Nitin Dahyabhai CLA 2011-07-11 09:47:50 EDT
Any issues possible with this.resolvedType not being set before some of the same method's returns?