Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350949 - [target] Unexternalized string in New Target Definition wizard
Summary: [target] Unexternalized string in New Target Definition wizard
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 353770
  Show dependency tree
 
Reported: 2011-07-01 11:39 EDT by Kit Lo CLA
Modified: 2011-08-03 10:06 EDT (History)
1 user (show)

See Also:

Attachments
Screen capture (33.91 KB, image/png)
2011-07-01 11:39 EDT, Kit Lo CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2011-07-01 11:39:01 EDT 
Created attachment 198975 [details]
Screen capture

Build ID: I20110628-0800

Scenario:
- From Preferences dialog, navigate to Plug-in Development > Target Platform
- Click "Add..." button to create a new target definition
- Click "Next >" on the New Target Definition wizard
- Click the "Content" tab
- The string "< no plug-ins found in the target >" is unexternalized
Comment 1 Kit Lo CLA 2011-07-03 17:57:09 EDT 
I found the string in "org.eclipse.pde.ui". The "<" & ">" in the string confused the pseudo translation generation :-). Resolved as INVALID.
Comment 2 Kit Lo CLA 2011-07-04 11:34:02 EDT 
I have a few more comments about this problem. After investigation, we found that the pseudo translation tool confused the string "< no plug-ins found in the target >" to be a HTML tag and skipped the pseudo translation generation.

I looked around to see how other areas in Eclipse presents the UI to user when there is nothing in a list. I usually just see an empty list without any message. Sometimes there maybe an informational message in the status area.

Just wonder if there is any room for improving the UI or the message. I'm okay if the answer is no.
Comment 3 Curtis Windatt CLA 2011-07-05 09:57:07 EDT 
The message was added to give users some indication why the tree was disabled.  The < > was added to make the item look different for an informational message vs actual content.  At a minimum, I think we can remove the < >, but perhaps the message could be removed entirely.
Comment 4 Curtis Windatt CLA 2011-07-21 15:44:20 EDT 
Fixed in HEAD.  See messages.properties in org.eclipse.pde.internal.ui.shared.target

I removed the <> and changed to sentence casing.  Also fixed PreviewContainerPage_0 which had the same style.
Comment 5 Kit Lo CLA 2011-07-21 17:11:11 EDT 
That's a good solution. Thanks!
Comment 6 Ankur Sharma CLA 2011-08-03 09:51:24 EDT 
Verified in I20110802-2000