Description Lan Phan 2011-07-01 07:38:05 EDT

Build Identifier: Eclipse 3.6.2

In case "editableName" = false, Name field always displays "<default>" through this code:
protected Control createDialogArea(Composite ancestor) {
...
if (editableName) {
	if (outlet.getName() != null) {
		nameText.setText(outlet.getName());
	}
	nameText.addModifyListener(listener);
} else {
	nameText.setText(Messages.label_default);
}
...
}

The code is not generic enough (usecase: user don't want to edit name of Outlet "abc", but Name field displays "<default>" - NOT OK).

Proposed solution:
if (outlet.getName() != null) {
	nameText.setText(outlet.getName());
}
if (editableName) {
	nameText.addModifyListener(listener);
} else {
	if (outlet.getName() == null) {
		nameText.setText(Messages.label_default);
	}
}

Reproducible: Always