Comment 1 Lazar Kirchev 2011-07-11 08:30:31 EDT

(In reply to comment #0)
> As the OBR spec is in flux and Virgo is making no attempt to add OBR support to
> p2, I think we should remove these commands as they will only prompt users to
> try integrating Felix OBR support which will result in much angst.

Gogo registers the OBR commands by default. Should see how we can fix this.

Comment 2 Lazar Kirchev 2011-07-18 03:05:48 EDT

The Gogo shell bundle registers these commands by default. Actually, they do not work, because there is no OBR repository. 
But we cannot unregister them either - it is not possible to unregister a service from a bundle, different from the one which registered it.
Is this a big problem?

Comment 3 Glyn Normington 2011-07-18 06:34:10 EDT

It's not a big problem, which is why this bug is classified as minor.

However, I don't think the Gogo bundle should register these commands by default, especially if they do not work. This is the kind of behaviour you would expect of monolithic software. I think OBR should provide and register the commands rather than having them registered by Gogo.

We have no plans to implement the OBR spec (once it has been standardised) in Virgo, so I would like a way of avoiding these commands.

Perhaps you could raise a bug against Gogo and link it up with this one?

Comment 4 Lazar Kirchev 2011-07-18 07:04:54 EDT

(In reply to comment #3)
> It's not a big problem, which is why this bug is classified as minor.
> 
> However, I don't think the Gogo bundle should register these commands by
> default, especially if they do not work. This is the kind of behaviour you
> would expect of monolithic software. I think OBR should provide and register
> the commands rather than having them registered by Gogo.
> 
> We have no plans to implement the OBR spec (once it has been standardised) in
> Virgo, so I would like a way of avoiding these commands.
> 
> Perhaps you could raise a bug against Gogo and link it up with this one?

Yes, I will open a bug - this seems to be the only possible thing we can do if we do not want to fork the Gogo project.

Comment 5 Glyn Normington 2011-07-18 07:06:57 EDT

Thanks very much Lazar. We certainly do not want to fork Gogo.

Comment 6 Lazar Kirchev 2011-07-19 04:44:58 EDT

Since we cannot directly unregister the commands, we will embed the Gogo command bundle in our own bundle, which will register only those commands from Gogo command, which we use. Thus we will have a new bundle on the place of Gogo command bundle.

Comment 7 Glyn Normington 2011-11-21 05:53:48 EST

Unfortunately, I think we have to live with this.

Comment 8 Lazar Kirchev 2011-11-21 06:03:29 EST

(In reply to comment #7)
> Unfortunately, I think we have to live with this.

Just to note that Tom Watson opened a bug against Felix to move the help command from the commands bundle to runtime bundle, so that we can drop the commands bundle at all. If this happens the problem with the OBR commands will get solved automatically.

Comment 9 Glyn Normington 2011-11-21 06:16:23 EST

(In reply to comment #8)
Thanks Lazar!

Comment 10 Lazar Kirchev 2012-04-30 08:26:07 EDT

(In reply to comment #8)
> (In reply to comment #7)
> > Unfortunately, I think we have to live with this.
> 
> Just to note that Tom Watson opened a bug against Felix to move the help
> command from the commands bundle to runtime bundle, so that we can drop the
> commands bundle at all. If this happens the problem with the OBR commands will
> get solved automatically.

For the record, the bug is https://issues.apache.org/jira/browse/FELIX-2340