Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350754 - Open corresponding task from EGit commits should expand comments near the time of the commit
Summary: Open corresponding task from EGit commits should expand comments near the tim...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.6.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 355990
Blocks: 355992
  Show dependency tree
 
Reported: 2011-06-29 18:40 EDT by Sam Davis CLA
Modified: 2011-08-26 19:40 EDT (History)
0 users

See Also:


Attachments
screesnhot (9.00 KB, image/png)
2011-07-27 17:19 EDT, Sam Davis CLA
no flags Details
mylyn/context/zip (1.22 KB, application/octet-stream)
2011-08-26 19:38 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-06-29 18:40:41 EDT
When using open corresponding task on a change set or an entry in the history view, it would useful if the comments in the task editor that were posted near the time of that commit were expanded.
Comment 1 Steffen Pingel CLA 2011-06-30 01:56:35 EDT
That should be the case. Can you provide steps to reproduce where this is not working?
Comment 2 Sam Davis CLA 2011-06-30 03:04:56 EDT
Interesting. I thought I remembered seeing that working, but it never happens when I want it to.

E.g.:
# open org.eclipse.mylyn.tasks.tests.LinkProviderTest in the history view
# Right click revision 1.2 and select Open Corresponding Task
# No comments are expanded

Perhaps this is related to 349473: task outline selection does not focus on comment for a task with many comments
https://bugs.eclipse.org/bugs/show_bug.cgi?id=349473
Comment 3 Steffen Pingel CLA 2011-07-26 13:56:32 EDT
There seems to be a regression indeed. If I open https://tasktop.com/bugs/show_bug.cgi?id=266 and navigate to coment 85 in the outline nothing happens.
Comment 4 Sam Davis CLA 2011-07-27 17:19:48 EDT
Created attachment 200478 [details]
screesnhot

Really? *Nothing* happens? For me it expands the comments section but leaves all comments collapsed (see screenshot).
Comment 5 Steffen Pingel CLA 2011-07-27 18:04:10 EDT
Fair enough (I already had comments expanded).
Comment 6 Steffen Pingel CLA 2011-08-26 19:38:48 EDT
Created attachment 202260 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2011-08-26 19:40:49 EDT
Looks like this was not supported in EGit and is also borked in various ways. I have opened bug 355990 to fix support in EGit and have also released a fix to the handling in the team framework which swallowed the timestamp in some cases.

I discovered though that this only works for tasks that are *not* in the task list. I have opened bug 355992 to address that.