Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350689 - [formatter] Problems formatting Lua source code
Summary: [formatter] Problems formatting Lua source code
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Anton Leherbauer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-29 07:29 EDT by Anton Leherbauer CLA
Modified: 2011-08-09 05:23 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2011-06-29 07:29:46 EDT 
I am testing the formatter using the Lua source code (version 5.1.4 from http://www.lua.org/download.html) and it seems this worked better with 7.0.2.
With 7.0.2 I get only one formatting problem in print.c. 
With 8.0, there are about 20 and some of the problems change the syntax causing build issues:

ldebug.c:231:3: warning: implicit declaration of function 'elsesetclvalue'
lopcodes.c:57:14: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'luaP_opmodes'
Comment 1 Anton Leherbauer CLA 2011-08-09 04:43:04 EDT 
Fixed in master and 8.0.1.
Comment 2 CDT Genie CLA 2011-08-09 05:23:01 EDT 
*** cdt git genie on behalf of Anton Leherbauer ***

    Bug 350689 - [formatter] Problems formatting Lua source code

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=17df657d34c805bbe4d446b5f4abac849d94cdc1
Comment 3 CDT Genie CLA 2011-08-09 05:23:02 EDT 
*** cdt git genie on behalf of Anton Leherbauer ***

    Bug 350689 - [formatter] Problems formatting Lua source code

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=24d603a17822c483de68459894cc264aa808a3c8