Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350636 - [client] Remove dojo dependency from TextMateStyler and HtmlGrammar
Summary: [client] Remove dojo dependency from TextMateStyler and HtmlGrammar
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.3 M1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL: https://github.com/eclipse/orion.clie...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 16:29 EDT by Mihai Sucan CLA
Modified: 2012-01-19 11:46 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Sucan CLA 2011-06-28 16:29:53 EDT 
Build Identifier: 

For Mozilla integration we use Orion TextView, without dojo, and no orion.editor code.

We would like the TextMateStyler dojo dependency removed - it's something really minor. The cost of integrating dojo into our codebase is much higher than fixing this here in Orion's code.

This is needed so we can enable HTML syntax highlighting in the Orion integration code (with the TextView component).

Will submit a pull request.

Thank you!

Reproducible: Always
Comment 1 Mihai Sucan CLA 2011-06-28 16:36:28 EDT 
Pull request submitted:

https://github.com/eclipse/orion.client/pull/6

I have also updated the TextView demo to include an HTML file, so users can play with this. TextMateStyler and HtmlGrammar no longer depend on the editor itself, which really fits with the idea of a TextView + syntax highlighters + and higher-level editor features.

Please let me know if further changes are needed for this to land. With this code we can use HTML syntax highlighting in our Orion integration work - which makes the patch really important for us. Thank you very much!
Comment 2 Mark Macdonald CLA 2011-06-29 10:13:02 EDT 
The patch looks good. Thanks Mihai!

But I need you to add a comment here confirming the usual legal song and dance, something like:

> "I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use."
Comment 3 Mihai Sucan CLA 2011-06-29 10:59:49 EDT 
I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.

Thanks for looking into the patch! Looking forward to see this land.