Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350634 - Cleanup FileResource construction
Summary: Cleanup FileResource construction
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.4.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 7.2.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 16:27 EDT by Michael Gorovoy CLA
Modified: 2011-09-20 15:52 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gorovoy CLA 2011-06-28 16:27:09 EDT 
Expose a FileResource(File) constructor that could be used to resolve ambiguities and avoid JVM encoding deficiencies. Remove Java 1.4 hack from FileResource(URL) constructor and make it work using standard Java methods.
Comment 1 Michael Gorovoy CLA 2011-06-28 21:00:19 EDT 
Committed r3434.
Comment 2 Michael Gorovoy CLA 2011-07-07 19:14:16 EDT 
Changes were reverted.
Comment 3 Greg Wilkins CLA 2011-09-06 00:28:35 EDT 
a File is used by Resource.newResource(String)
the gains for a FileResource(File) constructor are small and would need changes to Resource class constructors.

I've added a Resource.newResource(File) as a convenience.
Comment 4 Jesse McConnell CLA 2011-09-20 15:52:43 EDT 
Resolved -> Closed