Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350596 - [Compatibility] [breadcrumb] Cannot activate breadcrumb by re-sizing the Debug view in 4.x
Summary: [Compatibility] [breadcrumb] Cannot activate breadcrumb by re-sizing the Debu...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M7   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 11:19 EDT by Michael Rennie CLA
Modified: 2012-05-01 22:17 EDT (History)
6 users (show)

See Also:


Attachments
screenshot (25.06 KB, image/png)
2011-06-28 11:25 EDT, Michael Rennie CLA
no flags Details
Patch to change the percentage to 5% rather than 10% (2.03 KB, patch)
2011-08-09 14:48 EDT, Eric Moffatt CLA
no flags Details | Diff
Alternate fix...the original code wasn't calcualting the %'age correctly (2.06 KB, patch)
2011-08-10 10:05 EDT, Eric Moffatt CLA
no flags Details | Diff
screen shot (31.65 KB, image/png)
2012-04-24 14:58 EDT, Michael Rennie CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2011-06-28 11:19:07 EDT
Version: 4.1.0
Build id: I20110620-1631
Ubuntu 11.04, Gnome 3.0.2

Testing in 4.x I not found a way to get the breadcrumb to show up. No matter where I place the Debug View it will not let me shrink the view enough to activate the breadcrumb.
Comment 1 Michael Rennie CLA 2011-06-28 11:21:12 EDT
I should have noted that using the view menu allows me to put it in breadcrumb mode, but it looks ugly since I can't shrink the view enough to make it breadcrumb size.
Comment 2 Michael Rennie CLA 2011-06-28 11:25:11 EDT
Created attachment 198747 [details]
screenshot

The screenshot shows it as small as it will allow me to re-size it to
Comment 3 Pawel Piech CLA 2011-06-28 11:41:03 EDT
That's rather unfortunate.  The premise of having the "compact mode" is that the view can be resized to be compact.  

On a related note.  Our product marketing requested to have a "current program counter" indicator on the status bar, with the intent that it should allow debugging without Debug view open.  We talked about using the breadcrumb in this context, but it was deemed too comlex for the purpose.  However, the debug view provides a mechanism for viewing as well as selecting the active context, so we're still trying to figure out the workflow.
Comment 4 Paul Webster CLA 2011-06-29 09:16:10 EDT
Eric, are we shrinking the view composites when we shrink stacks?

PW
Comment 5 Remy Suen CLA 2011-07-13 14:09:32 EDT
It's a problem with our SashLayout I think. I also see this behaviour on Windows although it is technically possible to get it to be sized smaller if the containers below take up more space. Think of it like a 10-40-50 size split and then you can resize your view down. However, if you have it setup like a 10-80-10 split then it's not possible to downsize the stack to its extreme.
Comment 6 Eric Moffatt CLA 2011-08-09 14:48:54 EDT
Created attachment 201168 [details]
Patch to change the percentage to 5% rather than 10%


Perhaps we should look into making this CSS-able...
Comment 7 Eric Moffatt CLA 2011-08-10 10:05:41 EDT
Created attachment 201242 [details]
Alternate fix...the original code wasn't calcualting the %'age correctly
Comment 8 Eric Moffatt CLA 2011-08-10 14:25:31 EDT
Committed in >20110810. Applied the patch.
Comment 9 Remy Suen CLA 2011-09-13 08:28:47 EDT
It still seems to be possible for a user to get into a state where the resize operation is prohibited, Eric.
Comment 10 Pawel Piech CLA 2011-12-15 14:48:22 EST
(In reply to comment #9)
> It still seems to be possible for a user to get into a state where the resize
> operation is prohibited, Eric.

I'm also still seeing this problem when i try to place the Debug view above the editor.  In fact it seems that there is no way in 4.x to place a view _above_ the editor area, instead it somehow gets linked into the editor are such that when I open a new editor it stacks on top of my view.  Is this intended?  Thanks.
Comment 11 Pawel Piech CLA 2011-12-15 14:49:26 EST
(In reply to comment #10)
P.S. Maybe this is better tracked as a separate bug, since it's more than just a question of minimum view height.
Comment 12 John Arthorne CLA 2012-04-24 11:11:09 EDT
Please review target milestone and bump to > 4.2 if appropriate.
Comment 13 Michael Rennie CLA 2012-04-24 11:43:20 EDT
This annoys me to no end as well, I have stopped using the breadcrumb view because I can't place it above the editor area. I would love to see this fixed for M7.
Comment 14 Michael Rennie CLA 2012-04-24 14:39:56 EDT
(In reply to comment #13)
> This annoys me to no end as well, I have stopped using the breadcrumb view
> because I can't place it above the editor area. I would love to see this fixed
> for M7.

Chatting with Eric (and trying it again), you can drop the debug view above the editor stack now, it just looks like you are going to drop it in the editor stack while dragging.

Tested using:
Version: 4.2.0
Build id: N20120423-2000
Comment 15 Michael Rennie CLA 2012-04-24 14:45:58 EDT
(In reply to comment #14)

> Chatting with Eric (and trying it again), you can drop the debug view above the
> editor stack now, it just looks like you are going to drop it in the editor
> stack while dragging.

Fixed with changes for bug 372451. Marking fixed.
Comment 16 Michael Rennie CLA 2012-04-24 14:55:48 EDT
Got too excited, I found a sash problem.

If you do place the debug view above the editor stack you can shrink it down to be a breadcrumb like 3.8 (OK). Now if you start to move around the sash that separates the editor stack and the lower view area, the debug view also resizes (BAD). If you move the lower sash around enough you can break the debug view being able to enter breadcrumb mode.

I will attach a screen shot to show the layout I was testing with.
Comment 17 Michael Rennie CLA 2012-04-24 14:58:11 EDT
Created attachment 214490 [details]
screen shot
Comment 18 Pawel Piech CLA 2012-04-24 15:23:44 EDT
(In reply to comment #16)
> Got too excited, I found a sash problem.
The bigger problem for me is that if I place the debug view above the editor stack, then start debugging, then I get new editors opening in the same stack as the Debug view.
I'm seeing this with I20120411-0906 and I don't see a way to place the Debug view completely above the editor stack.
Comment 19 Pawel Piech CLA 2012-04-25 15:13:03 EDT
(In reply to comment #18)
> (In reply to comment #16)
> > Got too excited, I found a sash problem.
> The bigger problem for me is that if I place the debug view above the editor
> stack, then start debugging, then I get new editors opening in the same stack
> as the Debug view.
> I'm seeing this with I20120411-0906 and I don't see a way to place the Debug
> view completely above the editor stack.
Today, I actually managed to get the debug view placed above the editor stack.  As indicated though, the outlines made it appear otherwise, and I can't quite do it consistently (i.e. it works in the Debug perspective but not in the Java perspective).
Comment 20 Eric Moffatt CLA 2012-04-30 14:26:06 EDT
The sash sizing issue is independent of this defect. Now that you can actually place views above the editor area (and not *in* it) you can make this arrangement work.

Ive opened Bug 378105 to track this...
Comment 21 Michael Rennie CLA 2012-05-01 22:17:09 EDT
verified in:

Version: 4.2.0
Build id: I20120430-1800