Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350585 - Synchronize View: allow multi-selection for 'Commit'
Summary: Synchronize View: allow multi-selection for 'Commit'
Status: REOPENED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 10:04 EDT by Ulli Hafner CLA
Modified: 2015-04-29 18:14 EDT (History)
3 users (show)

See Also:


Attachments
Screenshot (362.59 KB, image/png)
2011-06-29 04:03 EDT, Ulli Hafner CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ulli Hafner CLA 2011-06-28 10:04:09 EDT
Build Identifier: I20110613-1736

Seems that multi-selection is possible for the elelements shown in the synchronize view, however the commit action is disabled then. It would be quite handy to allow that too. (In the package explorer this is possible).

Reproducible: Always
Comment 1 Dariusz Luksza CLA 2011-06-28 17:01:03 EDT
What resources do you selected ? (it was files, folders, projects or maybe mixed selection)

With commit action do you refer to, those in context menu in sync-view or different one?
Comment 2 Ulli Hafner CLA 2011-06-29 03:41:14 EDT
My workspace contains several projects from different git repositories. After synchronization, the changes for all these repositories are shown. I then selected the top-level Eclipse projects and tried to commit, which was disabled. Do you need a screenshot?
Comment 3 Dariusz Luksza CLA 2011-06-29 03:43:08 EDT
Yes, screenshot would be helpful.
Comment 4 Ulli Hafner CLA 2011-06-29 04:03:02 EDT
Created attachment 198794 [details]
Screenshot

What its basically missing in this view is also the commit button. There is only a button to merge all incoming changes but not the inverse. It's quite cumbersome to actually find the commit action in the eclipse menu hierarchy. This button is available on CVS and SVN view. Is there a reason that this view shows outgoing changes but does not support a simple way of committing these changes?
Comment 5 Dariusz Luksza CLA 2011-06-29 05:01:54 EDT
I never used 'Commit All Outgoing Changes...' button in CVS, therefore I didn't add such button into EGit and until now nobody mention about it. Feel free to open new enhancement bug for this feature.
Comment 6 Ulli Hafner CLA 2011-06-29 07:37:57 EDT
Just noticed that the commit action also disappears if you are selecting two resources from the same git project.
Comment 7 Dariusz Luksza CLA 2011-06-30 08:24:39 EDT
this should be fixed by change 3780[1]

[1] http://egit.eclipse.org/r/#change,3780
Comment 8 Robin Stocker CLA 2013-09-29 15:04:19 EDT
This is fixed in recent versions of EGit.
Comment 9 Ulli Hafner CLA 2013-12-11 10:05:11 EST
In which version is that fixed? In 3.0.0 this problem still exists...
Comment 10 Robin Stocker CLA 2013-12-11 10:23:01 EST
(In reply to Ulli Hafner from comment #9)
> In which version is that fixed? In 3.0.0 this problem still exists...

I just tested again (with 3.2), the context menu includes a "Commit..." entry as the first entry and is enabled when having multiple projects or files selected. This should be the case since 2.0.

If you have a specific situation where this is not possible, please describe it in a step-by-step description and include an up-to-date screenshot. If we can not reproduce the issue, a fix is not likely to happen.
Comment 11 Mauro Molinari CLA 2015-04-29 18:07:01 EDT
(In reply to Dariusz Luksza from comment #5)
> I never used 'Commit All Outgoing Changes...' button in CVS, therefore I
> didn't add such button into EGit and until now nobody mention about it. Feel
> free to open new enhancement bug for this feature.

See bug #350687 and its duplicates for this.
Comment 12 Mauro Molinari CLA 2015-04-29 18:14:07 EDT
(In reply to Robin Stocker from comment #10)
> If you have a specific situation where this is not possible, please describe
> it in a step-by-step description and include an up-to-date screenshot. If we
> can not reproduce the issue, a fix is not likely to happen.

I do have the Commit action for multi-selection, but I found bug #465861.