Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350581 - [dstore] FileClassifier should default to English
Summary: [dstore] FileClassifier should default to English
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 350582
  Show dependency tree
 
Reported: 2011-06-28 09:52 EDT by David McKnight CLA
Modified: 2011-06-30 15:06 EDT (History)
1 user (show)

See Also:
xuanchen: review+


Attachments
patch to default classification LANG to en_US (2.20 KB, patch)
2011-06-28 09:54 EDT, David McKnight CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-06-28 09:52:35 EDT
Remote file types like "executable" are determined by matching the classification with preset textual patterns.  This matching is currently based on English and has no translation.  Because of this, when running in other languages, such as Japanese, the classifier is not able to determine whether or not a given file is an executable or not and in turn, actions that are contributed to work against "executable" files don't work in these environments.

While it would be nice to see the classification field displayed in the appropriate language when viewing the property sheet, I think having the correct function is more important.  For file classification, we can run the "file" command using LANG=en_US but also provide the option (via a JVM property) to use the default language.
Comment 1 David McKnight CLA 2011-06-28 09:54:53 EDT
Created attachment 198726 [details]
patch to default classification LANG to en_US
Comment 2 David McKnight CLA 2011-06-28 09:55:19 EDT
Xuan, could you please review this?
Comment 3 Xuan Chen CLA 2011-06-28 10:29:18 EDT
The fix looks good.  Thanks.
Comment 4 David McKnight CLA 2011-06-28 10:52:36 EDT
Thanks for the review, Xuan.