Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350493 - [ast] TupleFactory.TupleInstance.equals() is invalid
Summary: [ast] TupleFactory.TupleInstance.equals() is invalid
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.2.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: OCL Inbox CLA
QA Contact:
URL:
Whiteboard: Legacy
Keywords:
Depends on: 349117
Blocks:
  Show dependency tree
 
Reported: 2011-06-27 15:41 EDT by Ed Willink CLA
Modified: 2013-05-20 11:37 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-06-27 15:41:15 EDT
Further to the EMF new group "EObject == Javadoc; was EcoreUtil.copy and String attributes" thread.

EObject has a contract (better written as):

The framework also assumes that implementations will not specialize {@link #equals(Object)} (nor {@link #hashCode()}) in a way that invalidates the use of "<code>==</code>" rather than {@link #equals(Object)} for equality testing;

This contract is not satisfied by TupleFactory.TupleInstance or by two test classes.

[This is not a problem for the pivot code since the pivot values do not extend EObject.]
Comment 1 Ed Willink CLA 2012-05-02 15:21:09 EDT
This is fixed by the Bug 349117 elimination of TupleFactory and TupeInstance.
Comment 2 Ed Willink CLA 2012-05-04 13:10:26 EDT
Pushed to master.
Comment 3 Ed Willink CLA 2013-05-20 11:37:18 EDT
CLOSED after a year in the RESOLVED state.