Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350473 - Change JavaGen aliasing scheme
Summary: Change JavaGen aliasing scheme
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 13:37 EDT by Matt Heitz CLA
Modified: 2017-02-23 14:18 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Heitz CLA 2011-06-27 13:37:37 EDT
In RBD 7 we changed the escape character in aliases from $ to _, and everybody hated it because underscores are used in names much more often than dollar signs.

The change was made because the Eclipse Java compiler was occasionally getting confused and rejecting perfectly valid code, thinking that we were referencing nonexistent inner classes.  I believe this has been fixed for a long time.

We've been using underscores in the runtime and generated variables to avoid collisions with names from the user's EGL code.  We'll have to change them all back to dollar signs.
Comment 1 Matt Heitz CLA 2011-07-08 14:15:27 EDT
Actually, we should have no alias character at all.  Every valid EGL identifier is a valid Java identifier, except for EGL identifiers which are Java keywords.  We should alias Java keywords using a prefix of "eze_" ("throws" -> "eze_throws") and leave everything else alone.  All identifiers that we create internally should begin with something like "ezez" which won't conflict with aliases for Java keywords.
Comment 2 Jeff Douglas CLA 2011-07-11 16:01:49 EDT
The java aliaser has been changed to remove the hex logic and prefix special words with eze_.
Comment 3 Matt Heitz CLA 2011-07-12 10:35:20 EDT
Looking good.