Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350452 - NPE RevWalk.parseAny -> ObjectIdOwnerMap.get
Summary: NPE RevWalk.parseAny -> ObjectIdOwnerMap.get
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 1.1   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 1.1-M1   Edit
Assignee: Dariusz Luksza CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 10:19 EDT by James Blackburn CLA
Modified: 2011-06-27 10:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Blackburn CLA 2011-06-27 10:19:30 EDT 
Eclipse EGit	1.1.0.201106251716	org.eclipse.egit.feature.group	Eclipse EGit
  Eclipse JGit	1.1.0.201106251706	org.eclipse.jgit.feature.group	Eclipse JGit

Trying to do a Team > Share Project on a clone of the CDT git repo, I get a NPE and attaching the egit team provider fails:

java.lang.NullPointerException
	at org.eclipse.jgit.lib.ObjectIdOwnerMap.get(ObjectIdOwnerMap.java:131)
	at org.eclipse.jgit.revwalk.RevWalk.parseAny(RevWalk.java:809)
	at org.eclipse.jgit.revwalk.RevWalk.parseCommit(RevWalk.java:724)
	at org.eclipse.egit.core.synchronize.dto.GitSynchronizeData.updateRevs(GitSynchronizeData.java:131)
	at org.eclipse.egit.core.synchronize.dto.GitSynchronizeData.<init>(GitSynchronizeData.java:120)
	at org.eclipse.egit.core.internal.GitRepositoryProviderType.getSubscriber(GitRepositoryProviderType.java:35)
	at org.eclipse.team.internal.ui.TeamUIPlugin.getDecoratedStateProvider(TeamUIPlugin.java:444)
	at org.eclipse.team.internal.ui.TeamAdapterFactory.getAdapter(TeamAdapterFactory.java:56)
	at org.eclipse.core.internal.adapter.AdapterFactoryProxy.getAdapter(AdapterFactoryProxy.java:80)
	at org.eclipse.core.internal.runtime.AdapterManager.getAdapter(AdapterManager.java:295)
	at org.eclipse.core.runtime.PlatformObject.getAdapter(PlatformObject.java:66)
	at org.eclipse.team.internal.ui.Utils.getAdapter(Utils.java:676)
	at org.eclipse.team.internal.ui.mapping.WorkspaceTeamStateProvider.getDecoratedStateProviderForId(WorkspaceTeamStateProvider.java:130)
	at org.eclipse.team.internal.ui.mapping.WorkspaceTeamStateProvider.listenerForStateChangesForId(WorkspaceTeamStateProvider.java:185)
	at org.eclipse.team.internal.ui.mapping.WorkspaceTeamStateProvider.providerMapped(WorkspaceTeamStateProvider.java:212)
	at org.eclipse.team.internal.core.RepositoryProviderManager.providerMapped(RepositoryProviderManager.java:36)
	at org.eclipse.team.core.RepositoryProvider.map(RepositoryProvider.java:139)
	at org.eclipse.egit.core.op.ConnectProviderOperation.execute(ConnectProviderOperation.java:148)
	at org.eclipse.egit.ui.internal.sharing.SharingWizard$2.run(SharingWizard.java:133)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Comment 1 Dariusz Luksza CLA 2011-06-27 10:39:01 EDT 
This is an EGit bug, because we don't prevent from passing null argument into RevWalk.parseCommit().

Change 3785[1] should fix this issue.

[1] http://egit.eclipse.org/r/3785
Comment 2 Chris Aniszczyk CLA 2011-06-27 10:52:00 EDT 
Fixed in master, thanks for being quick Dariusz.
Comment 3 Dariusz Luksza CLA 2011-06-27 10:55:29 EDT 
(In reply to comment #2)
> Fixed in master, thanks for being quick Dariusz.

No problem, this was very trivial issue to fix ;)