Community
Participate
Working Groups
Steps: 1) Create a file in the navigator 2) Open the file in two editors 3) Modify the file content in the first editor and save, then do the same in the other editor See that the content is silently overridden. We should notify the user, that the content was changed in the meantime and he is going to override it.
Proposal: https://github.com/pjanik/orion.server/tree/bug350410 https://github.com/pjanik/orion.client/tree/bug350410 I wrote all this code and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comments: 1) ETag is returned only for requests with the 'parts' attribute e.g. http://localhost:8080/file/h/TODO.txt?parts=meta. For http://localhost:8080/file/h/TODO.txt there is no ETag. Moreover it is not returned at all for the generic handler. 2) We need to change the signature of #write in fileClient.js too 3) I would consider renaming 'etag' arg in #write to metadata or args or something like this. Then we could pass more arguments to #write if necessary without changing the signature.
Fixed.
Fixed with 921c3dbcb1db513af5a227791d62f31892c4c4ac and f736a3053fe9694d8b2e45c6c8f3620a0460dec4.
The fix of this bug caused regression on compare editor addressed by bug 352165 , which was fixed.
