350395 – NPE in SystemView.updatePropertySheet()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 350395 - NPE in SystemView.updatePropertySheet()

Summary: NPE in SystemView.updatePropertySheet()

Status:	RESOLVED FIXED

Alias:	None

Product:	Target Management
Classification:	Tools
Component:	RSE (show other bugs)
Version:	3.0.3
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.0.3+
Assignee:	David McKnight
QA Contact:	Martin Oberhuber

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-06-27 01:20 EDT by Masao Nishimoto
Modified:	2011-06-29 11:40 EDT (History)
CC List:	2 users (show)

See Also:

Flags:	xuanchen: review+

Attachments
patch to check for null (2.97 KB, patch) 2011-06-27 16:18 EDT, David McKnight	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Masao Nishimoto

2011-06-27 01:20:19 EDT

This is R3_0 maintenance stream.  The stack trace is as follows.  At the time of the NPE, "selection" is empty, and "first" is null.

Caused by: java.lang.NullPointerException
	at org.eclipse.rse.internal.ui.view.SystemView.updatePropertySheet(SystemView.java:5896)
	at org.eclipse.rse.internal.ui.view.SystemView.updatePropertySheet(SystemView.java:5875)
	at org.eclipse.rse.internal.ui.view.SystemView$7.run(SystemView.java:1421)

Comment 1 David McKnight

2011-06-27 16:18:05 EDT

Created attachment 198684 [details]
patch to check for null

Comment 2 David McKnight

2011-06-27 16:18:49 EDT

Masao, does the attached patch fix the problem?

Comment 3 Masao Nishimoto

2011-06-28 23:28:09 EDT

The patch fixed the problem.

Comment 4 David McKnight

2011-06-29 08:48:15 EDT

Xuan, could you please review this patch?

Comment 5 Xuan Chen

2011-06-29 11:34:43 EDT

The fix looks good.  Thanks.

Comment 6 David McKnight

2011-06-29 11:40:20 EDT

Thanks for the review, Xuan. I've committed the changes to the R3_0_maintenance stream.