Description Mekk Elek 2011-06-26 12:52:39 EDT

Build Identifier: 20110218-0911

I have a command and a RegistryToggleState state atteched to it. I subscribe for command state changes from code using:
public final void addCommandListener(final ICommandListener commandListener);

When a state change occurs in the State object, I get no notification at all. When I track down with debugger why, I can see that the event ends up in org.eclipse.ui.internal.handlers.HandlerProxy's method:
public void handleStateChange(State state, Object oldValue);

But this method, even though the "handler" variable is my command listener, will not call my function, because it is implementing the ICommandListener interface and not IStateListener, which this method expects:

if (handler instanceof IStateListener) {
  ((IStateListener) handler).handleStateChange(state, oldValue);
}

Note that ICommandListener and IStateListener are unrelated interfaces.

I would expect that if I call addCommandListener(), I should get back notifications, no matter what.

I have attached a snapshot of my complete eclipse project, which should be enough to check the fault.


Reproducible: Always

Steps to Reproduce:
1. Open the attched eclipse project.
2. When you start the project, you will see a file system view with some buttons on the toolbar. Press the "Show directories on top" button (it has this text as a tooltip).
3. Now the fsview.views.FSView :: public void commandChanged(CommandEvent commandEvent) should be fired, but this does not happen.
4. You can put a breakpoint to fsview.handlers.ToggleCommandHandler :: public Object execute(ExecutionEvent event) method and take step by step and you will reach org.eclipse.ui.internal.handlers.HandlerProxy.