Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350230 - Add back unique disabled icon support for ToolItems
Summary: Add back unique disabled icon support for ToolItems
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Dean Roberts CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 334303
  Show dependency tree
 
Reported: 2011-06-24 06:37 EDT by Markus Keller CLA
Modified: 2012-03-13 06:31 EDT (History)
9 users (show)

See Also:

Attachments
Screenshots (34.76 KB, image/png)
2011-06-24 06:37 EDT, Markus Keller CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-06-24 06:37:02 EDT 
Created attachment 198517 [details]
Screenshots

Bad rendering of disabled icons in main toolbar.
Screenshot shows 3.7 in the back and 4.1 in front.
Comment 1 Prakash Rangaraj CLA 2011-06-25 19:41:59 EDT 
I guess the bug is with e4. Moving...
Comment 2 Markus Keller CLA 2011-06-27 06:16:43 EDT 
Version: 4.1.0
Build id: I20110620-1631
Comment 3 Markus Keller CLA 2011-11-11 12:06:29 EST 
Still in I20111110-2200.
Comment 4 Neil Hauge CLA 2012-01-11 16:13:20 EST 
This would seem important to fix for Juno.
Comment 5 Remy Suen CLA 2012-01-13 11:07:03 EST 
Wonder if we need to introduce a disabledIconURI feature to MUILabel or MItem?
Comment 6 Eric Moffatt CLA 2012-01-30 14:53:55 EST 
If enablement is not an attribute in the model we could use a tag...
Comment 7 Dean Roberts CLA 2012-02-23 15:18:38 EST 
Fixed with

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3e63299b07847e6a4a02c58cca80a993f1905da8

For now just storing the iconURI as transient data on the model object.

Going forward, I believe we need to give some thought on how to represent the various flavours of icons in the model.

I will open a separate defect for this discussion.
Comment 8 Dani Megert CLA 2012-03-13 06:31:47 EDT 
Verified in 4.2-I20120312-1730.