Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350198 - [unifyprofiling] Standardize look and feel of results table
Summary: [unifyprofiling] Standardize look and feel of results table
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: GCov (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0   Edit
Assignee: Xavier Raynaud CLA
QA Contact: Xavier Raynaud CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 17:24 EDT by Andrew Overholt CLA
Modified: 2011-12-06 11:51 EST (History)
1 user (show)

See Also:

Attachments
Screenshot of gprof table result with a single color for percentage column (47.07 KB, image/png)
2011-12-06 07:58 EST, Xavier Raynaud CLA 		no flags Details
Screenshot of gprof table result without bacground color for percentage column (47.48 KB, image/png)
2011-12-06 07:59 EST, Xavier Raynaud CLA 		no flags Details
The same as #207976, but with lower opacity (36.93 KB, image/png)
2011-12-06 11:39 EST, Xavier Raynaud CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2011-06-23 17:24:56 EDT 
The background gradients in the results tables of the GProf and GCov plugins are unique and do not really match other eclipse.org projects.  We should see about standardizing them.
Comment 1 Andrew Overholt CLA 2011-09-30 15:17:54 EDT 
Updating Xavier's email address for existing bugs.
Comment 2 Xavier Raynaud CLA 2011-10-19 11:29:13 EDT 
Ok for me.
I can completely remove them, or replace this ugly gradient by a single color (SWT.COLOR_LIST_SELECTION is a good candidate).

What's your preference ?
Comment 3 Andrew Overholt CLA 2011-10-20 15:44:49 EDT 
I'm not sure :)  Is it easy to provide screenshots of both options (blank or a single colour)?  I think OProfile just uses a blank background.
Comment 4 Andrew Overholt CLA 2011-11-24 17:30:10 EST 
Here's a screenshot of how the OProfile plugin does it:

http://wiki.eclipse.org/images/c/cf/Screenshot-oprofile_view_full.png

I'm perfectly fine having it changed, too.
Comment 5 Xavier Raynaud CLA 2011-12-06 07:58:23 EST 
Created attachment 207976 [details]
Screenshot of gprof table result with a single color for percentage column

Screenshot of gprof table result with a single color for percentage column
Comment 6 Xavier Raynaud CLA 2011-12-06 07:59:00 EST 
Created attachment 207977 [details]
Screenshot of gprof table result without bacground color for percentage column

Screenshot of gprof table result without bacground color for percentage column
Comment 7 Andrew Overholt CLA 2011-12-06 09:27:29 EST 
I like the single colour best.  Can we lower the opacity on it at all?  Does it use a colour from the current theme?

Thanks for creating these screenshots!
Comment 8 Xavier Raynaud CLA 2011-12-06 09:59:07 EST 
The first screenshot uses SWT.COLOR_LIST_SELECTION for painting the background rectangle. It's of course possible to lower the opacity.
Comment 9 Andrew Overholt CLA 2011-12-06 10:20:28 EST 
(In reply to comment #8)
> The first screenshot uses SWT.COLOR_LIST_SELECTION for painting the background
> rectangle. It's of course possible to lower the opacity.

Awesome.  I'll leave it up to you to decide the level of opacity and going with SWT.COLOR_LIST_SELECTION is a great call.

Thanks again, Xavier.
Comment 10 Xavier Raynaud CLA 2011-12-06 11:39:33 EST 
Created attachment 208002 [details]
The same as #207976, but with lower opacity

The same as #207976, but with lower opacity